delay destructiuon of rocksdb checkpoint handle #4740
Closed
+58
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D80564473 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jiayulu
force-pushed
the
export-D80564473
branch
from
838edba to
45cf737
Compare
jiayulu
added a commit
to jiayulu/FBGEMM
that referenced
this pull request
Aug 20, 2025
Summary: X-link: facebookresearch/FBGEMM#1761 delay the destruction of rocksdb checkpoint handle, so that rdb checkpoint handle can be used multiple times. this is a stopgap measure for the silvertorch publishing use case, until the rdb checkpoint lifecycle unification effort is ready. Reviewed By: duduyi2013 Differential Revision: D80564473
jiayulu
added a commit
to jiayulu/FBGEMM
that referenced
this pull request
Aug 20, 2025
Summary: X-link: facebookresearch/FBGEMM#1761 delay the destruction of rocksdb checkpoint handle, so that rdb checkpoint handle can be used multiple times. this is a stopgap measure for the silvertorch publishing use case, until the rdb checkpoint lifecycle unification effort is ready. Reviewed By: duduyi2013 Differential Revision: D80564473
jiayulu
force-pushed
the
export-D80564473
branch
from
45cf737 to
5607376
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80564473 |
jiayulu
added a commit
to jiayulu/FBGEMM
that referenced
this pull request
Aug 20, 2025
Summary: Pull Request resolved: pytorch#4740 X-link: facebookresearch/FBGEMM#1761 delay the destruction of rocksdb checkpoint handle, so that rdb checkpoint handle can be used multiple times. this is a stopgap measure for the silvertorch publishing use case, until the rdb checkpoint lifecycle unification effort is ready. Reviewed By: duduyi2013 Differential Revision: D80564473
jiayulu
force-pushed
the
export-D80564473
branch
from
5607376 to
2f02195
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80564473 |
2 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D80564473 |
|
This pull request was exported from Phabricator. Differential Revision: D80564473 |
jiayulu
added a commit
to jiayulu/FBGEMM
that referenced
this pull request
Aug 20, 2025
Summary: Pull Request resolved: pytorch#4740 X-link: facebookresearch/FBGEMM#1761 delay the destruction of rocksdb checkpoint handle, so that rdb checkpoint handle can be used multiple times. this is a stopgap measure for the silvertorch publishing use case, until the rdb checkpoint lifecycle unification effort is ready. Reviewed By: duduyi2013 Differential Revision: D80564473
jiayulu
force-pushed
the
export-D80564473
branch
from
2f02195 to
17a91e1
Compare
Summary: X-link: facebookresearch/FBGEMM#1761 delay the destruction of rocksdb checkpoint handle, so that rdb checkpoint handle can be used multiple times. this is a stopgap measure for the silvertorch publishing use case, until the rdb checkpoint lifecycle unification effort is ready. Reviewed By: duduyi2013 Differential Revision: D80564473
jiayulu
force-pushed
the
export-D80564473
branch
from
17a91e1 to
e8806f2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80564473 |
|
This pull request has been merged in 58b6a87. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/1761
delay the destruction of rocksdb checkpoint handle, so that rdb checkpoint handle can be used multiple times.
this is a stopgap measure for the silvertorch publishing use case, until the rdb checkpoint lifecycle unification effort is ready.
Reviewed By: duduyi2013
Differential Revision: D80564473