Remove dry run #4746
Closed
Remove dry run #4746
+316
−470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D80425794 |
Summary: Previously we are using dry run to scan all weight blocks in backend and assign each feature score into eviction bucket and calculate the eviction threshold. This diff is removing dry run process and put the process assign eviction bucket into update and eviction block. This can save half time about total eviction duration. Reviewed By: emlin Differential Revision: D80425794
EddyLXJ
force-pushed
the
export-D80425794
branch
from
ce6ff5b to
f372505
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80425794 |
EddyLXJ
added a commit
to EddyLXJ/FBGEMM-1
that referenced
this pull request
Aug 21, 2025
Summary: X-link: facebookresearch/FBGEMM#1769 Previously we are using dry run to scan all weight blocks in backend and assign each feature score into eviction bucket and calculate the eviction threshold. This diff is removing dry run process and put the process assign eviction bucket into update and eviction block. This can save half time about total eviction duration. Reviewed By: emlin Differential Revision: D80425794
|
This pull request has been merged in bfee159. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/1769
Rollback Plan:
Differential Revision: D80425794