Add api for group wise low bit quantization, using codebook utils provided by coreml #2679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2679
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a54a372 with merge base 6cfa477 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79119940 |
szyszyzys
added
the
topic: not user facing
|
Requires linting with ruff |
szyszyzys
force-pushed
the
export-D79119940
branch
from
55628be to
cb1b625
Compare
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 6, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
|
This pull request was exported from Phabricator. Differential Revision: D79119940 |
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 6, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
szyszyzys
force-pushed
the
export-D79119940
branch
from
cb1b625 to
dae90c6
Compare
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 6, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 6, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 6, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
metascroy
approved these changes
Aug 7, 2025
metascroy
reviewed
Aug 7, 2025
|
|
||
|
|
||
| @torch.no_grad | ||
| def _quantize_row_wise_with_coreml_no_scales( |
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, will change this function to be align with the latest version of the coreml implementation.
metascroy
reviewed
Aug 7, 2025
|
|
||
|
|
||
| @torch.no_grad | ||
| def _dequantize_row_wise_with_coreml_no_scales( |
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, will change this function to be align with the latest version of the coreml implementation.
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 7, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 7, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 7, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 7, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
szyszyzys
force-pushed
the
export-D79119940
branch
from
dae90c6 to
205b0c9
Compare
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 7, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
szyszyzys
force-pushed
the
export-D79119940
branch
from
205b0c9 to
f0c45f5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79119940 |
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 8, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
szyszyzys
force-pushed
the
export-D79119940
branch
from
bbeea83 to
d2aad77
Compare
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 8, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
szyszyzys
force-pushed
the
export-D79119940
branch
from
d2aad77 to
7374ba9
Compare
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 8, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 8, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
szyszyzys
force-pushed
the
export-D79119940
branch
from
7374ba9 to
c3681bf
Compare
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 8, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
|
This pull request was exported from Phabricator. Differential Revision: D79119940 |
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 8, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 8, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Differential Revision: D79119940 Reviewed By: metascroy
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 8, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
szyszyzys
force-pushed
the
export-D79119940
branch
from
c3681bf to
4bb48e1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79119940 |
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 8, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
szyszyzys
force-pushed
the
export-D79119940
branch
from
4bb48e1 to
9eb38f8
Compare
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 8, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
szyszyzys
force-pushed
the
export-D79119940
branch
from
9eb38f8 to
919bf9b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79119940 |
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 8, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
szyszyzys
force-pushed
the
export-D79119940
branch
from
919bf9b to
74a1c92
Compare
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
szyszyzys
force-pushed
the
export-D79119940
branch
from
74a1c92 to
a54a372
Compare
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 8, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 8, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
|
This pull request was exported from Phabricator. Differential Revision: D79119940 |
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 8, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 8, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Differential Revision: D79119940 Reviewed By: metascroy
szyszyzys
added a commit
to szyszyzys/ao
that referenced
this pull request
Aug 8, 2025
…vided by coreml (pytorch#2679) Summary: Pull Request resolved: pytorch#2679 Reviewed By: metascroy Differential Revision: D79119940
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed By: metascroy
Differential Revision: D79119940