Skip to content

[not for land] float8 debug recipe for float8 rowwise fwd and hp bwd #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Aug 7, 2025

Summary:

  • fwd_rowwise_gi_rowwise_gw_hp - fwd and gi in rowwise, gw in high precision
    • on LLaMa 3 8B, only a 1.7% perf regression vs rowwise_with_gw_hp
  • fwd_float8_bwd_hp - fwd in rowwise, bwd in high precision

Test Plan:

with-proxy
CONFIG_FILE="./torchtitan/models/llama3/train_configs/debug_model.toml"
./run_train.sh --model.print_after_conversion --model.converters float8
--training.compile --float8.recipe_name fwd_float8_bwd_hp

with-proxy CONFIG_FILE="./torchtitan/models/llama3/train_configs/llama3_8b.toml" ./run_train.sh --model.print_after_conversion --model.converters float8 --float8.recipe_name fwd_rowwise_gi_rowwise_gw_hp --training.steps 50 --training.compile

Reviewers:

Subscribers:

Tasks:

Tags:

Summary:

Test Plan:

```bash
with-proxy
CONFIG_FILE="./torchtitan/models/llama3/train_configs/debug_model.toml"
./run_train.sh --model.print_after_conversion --model.converters float8
--training.compile --float8.recipe_name fwd_float8_bwd_hp
```

Reviewers:

Subscribers:

Tasks:

Tags:
Copy link

pytorch-bot bot commented Aug 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2708

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit f0a01fb with merge base 785f3dd (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 7, 2025
@facebook-github-bot
Copy link
Contributor

@vkuzo has imported this pull request. If you are a Meta employee, you can view this in D79777987.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants