Skip to content

[moe training] update tests and benchmarks for torchtitan moe refactor #2718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danielvegamyhre
Copy link
Contributor

@danielvegamyhre danielvegamyhre commented Aug 8, 2025

Summary

pytorch/torchtitan#1534 landed in torchtitan, a refactor which provides a generic MoE implementation that can be configured and used by both Llama4 and DeepSeekV3. We need to refactor our MoE training integration tests accordingly.

Test plan

  • pytest test/prototype/moe_training/test_training.py -s

Notes

  • I replace logger.info calls with print statements because the logging calls don't show up when running pytest tests, even with the "-s" flag. I don't love this but these log statements are only there temporarily for the development process anyway, until the prototype is more mature. If anyone has any better ideas let me know.

@danielvegamyhre danielvegamyhre added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Aug 8, 2025
Copy link

pytorch-bot bot commented Aug 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2718

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e080d55 with merge base 1526dfe (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 8, 2025
@danielvegamyhre
Copy link
Contributor Author

cc @vkuzo @drisspg @HDCharles if one of you could review that would be great

@danielvegamyhre danielvegamyhre changed the title [moe training] update tests for torchtitan moe refactor [moe training] update tests and benchmarks for torchtitan moe refactor Aug 8, 2025
@danielvegamyhre danielvegamyhre marked this pull request as draft August 8, 2025 18:19
@danielvegamyhre danielvegamyhre force-pushed the refac branch 2 times, most recently from 9a63ce6 to 8f694f9 Compare August 8, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant