-
Notifications
You must be signed in to change notification settings - Fork 317
Remove old change_linear_weights_to_*
APIs
#2721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
e1d7de3
Deprecate old TORCH_VERSION variables
andrewor14 922fc3e
Update on "Deprecate old TORCH_VERSION variables"
andrewor14 fc7dffe
Drop support for PyTorch 2.5 and before
andrewor14 42f9081
Remove old `change_linear_weights_to_*` APIs
andrewor14 83fb739
Update base for Update on "Remove old `change_linear_weights_to_*` APIs"
andrewor14 afedb9f
Update on "Remove old `change_linear_weights_to_*` APIs"
andrewor14 4697b22
Update base for Update on "Remove old `change_linear_weights_to_*` APIs"
andrewor14 da64318
Update on "Remove old `change_linear_weights_to_*` APIs"
andrewor14 ac6c78f
Update base for Update on "Remove old `change_linear_weights_to_*` APIs"
andrewor14 4d93ac7
Update on "Remove old `change_linear_weights_to_*` APIs"
andrewor14 d6c4715
Update base for Update on "Remove old `change_linear_weights_to_*` APIs"
andrewor14 d4762be
Update on "Remove old `change_linear_weights_to_*` APIs"
andrewor14 7980103
Update base for Update on "Remove old `change_linear_weights_to_*` APIs"
andrewor14 415cd55
Update on "Remove old `change_linear_weights_to_*` APIs"
andrewor14 2ae8eb6
Update base for Update on "Remove old `change_linear_weights_to_*` APIs"
andrewor14 6f4397e
Update on "Remove old `change_linear_weights_to_*` APIs"
andrewor14 670dccf
Update base for Update on "Remove old `change_linear_weights_to_*` APIs"
andrewor14 e15eaa6
Update on "Remove old `change_linear_weights_to_*` APIs"
andrewor14 cc84d2e
Update base for Update on "Remove old `change_linear_weights_to_*` APIs"
andrewor14 afa2c5b
Update on "Remove old `change_linear_weights_to_*` APIs"
andrewor14 68df77e
Update base for Update on "Remove old `change_linear_weights_to_*` APIs"
andrewor14 0bacdfd
Update on "Remove old `change_linear_weights_to_*` APIs"
andrewor14 158a8bc
Update base for Update on "Remove old `change_linear_weights_to_*` APIs"
andrewor14 a5f8df2
Update on "Remove old `change_linear_weights_to_*` APIs"
andrewor14 96cf2aa
Update base for Update on "Remove old `change_linear_weights_to_*` APIs"
andrewor14 af3d9dc
Update on "Remove old `change_linear_weights_to_*` APIs"
andrewor14 4d73e5b
Merge branch 'main' into gh/andrewor14/21/head
andrewor14 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file can be deleted as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also probably https://github.com/pytorch/ao/blob/6cfa47705f60ea614695b52b4b120ac5fd84d1cb/torchao/quantization/dynamic_quant.py and https://github.com/pytorch/ao/blob/6cfa47705f60ea614695b52b4b120ac5fd84d1cb/torchao/quantization/weight_only.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like classes from this file is still being used in autoquant. I don't think we can delete or even deprecate yet...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, created an issue here instead: #2745. Let's do them separately because there are autoquant/benchmark dependencies