-
Notifications
You must be signed in to change notification settings - Fork 535
Allow more variable input to LLMAttributionResult #1627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fy-meng
wants to merge
1
commit into
pytorch:master
Choose a base branch
from
fy-meng:export-D78197863
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was exported from Phabricator. Differential Revision: D78197863 |
fy-meng
added a commit
to fy-meng/captum
that referenced
this pull request
Jul 15, 2025
Summary: 1. Allow `LLMAttributionResult` to be initialized with generic array data (lists, np.ndarray) and perform sanity checks on their shapes; 2. During visualization, the text tokens are now `repr`'d to make sure that non-word charactures (e.g. newline) are visualized correctly. Differential Revision: D78197863
ef9f4ea
to
4f406f4
Compare
This pull request was exported from Phabricator. Differential Revision: D78197863 |
fy-meng
added a commit
to fy-meng/captum
that referenced
this pull request
Jul 15, 2025
Summary: Pull Request resolved: pytorch#1627 1. Allow `LLMAttributionResult` to be initialized with generic array data (lists, np.ndarray) and perform sanity checks on their shapes; 2. During visualization, the text tokens are now `repr`'d to make sure that non-word charactures (e.g. newline) are visualized correctly. Differential Revision: D78197863
4f406f4
to
6fbe744
Compare
fy-meng
added a commit
to fy-meng/captum
that referenced
this pull request
Jul 16, 2025
Summary: 1. Allow `LLMAttributionResult` to be initialized with generic array data (lists, np.ndarray) and perform sanity checks on their shapes; 2. During visualization, the text tokens are now `repr`'d to make sure that non-word charactures (e.g. newline) are visualized correctly. Reviewed By: craymichael Differential Revision: D78197863
6fbe744
to
5039018
Compare
This pull request was exported from Phabricator. Differential Revision: D78197863 |
fy-meng
added a commit
to fy-meng/captum
that referenced
this pull request
Jul 16, 2025
Summary: Pull Request resolved: pytorch#1627 1. Allow `LLMAttributionResult` to be initialized with generic array data (lists, np.ndarray) and perform sanity checks on their shapes; 2. During visualization, the text tokens are now `repr`'d to make sure that non-word charactures (e.g. newline) are visualized correctly. Reviewed By: craymichael Differential Revision: D78197863
5039018
to
052133f
Compare
fy-meng
added a commit
to fy-meng/captum
that referenced
this pull request
Jul 17, 2025
Summary: 1. Allow `LLMAttributionResult` to be initialized with generic array data (lists, np.ndarray) and perform sanity checks on their shapes; 2. During visualization, the text tokens are now `repr`'d to make sure that non-word charactures (e.g. newline) are visualized correctly. Reviewed By: craymichael Differential Revision: D78197863
052133f
to
831dea5
Compare
Summary: Pull Request resolved: pytorch#1627 1. Allow `LLMAttributionResult` to be initialized with generic array data (lists, np.ndarray) and perform sanity checks on their shapes; 2. During visualization, the text tokens are now `repr`'d to make sure that non-word charactures (e.g. newline) are visualized correctly. Reviewed By: craymichael Differential Revision: D78197863
This pull request was exported from Phabricator. Differential Revision: D78197863 |
831dea5
to
ab212c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
LLMAttributionResult
to be initialized with generic array data (lists, np.ndarray) and perform sanity checks on their shapes;repr
'd to make sure that non-word charactures (e.g. newline) are visualized correctly.Differential Revision: D78197863