-
Notifications
You must be signed in to change notification settings - Fork 645
Add support for aten.min.dim #12623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add support for aten.min.dim #12623
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12623
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 23f09da with merge base 7a37676 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D78526966 |
This PR needs a
|
@haowhsu-quic @shewu-quic @DannyYuyang-quic @winskuo-quic I ran into some issues to lower an internal model to QNN and this is one of the missing ops. I think the output are two nodes, while the regular min output is one node. Do you think we should re-use the |
Summary: Rollback Plan: Differential Revision: D78526966
1069ff4
to
23f09da
Compare
This pull request was exported from Phabricator. Differential Revision: D78526966 |
Actually, seems like the min operator in HTP doesn't support returning index, we may need to decompose |
Yes, looks like the most similar one is ReduceMin. But it cannot return index. |
Thanks for catching that, I’ll handle the min.dim op support |
Thanks! That will be super helpful. I find that we need to have 2 more ops...can we have the following ops supported?
|
Yes sure, could you please also share the source(testcase) for |
Something like this will be helpful
|
Regarding |
Summary: Rollback Plan: Differential Revision: D78526966
Summary: Rollback Plan: Differential Revision: D78526966
Summary: Rollback Plan: Differential Revision: D78526966
Differential Revision: D78526966