Move verification to after to_backend #12630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12630
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit dbf5b20 with merge base 413dee4 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78535519 |
This PR needs a
|
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jul 18, 2025
Summary: Some operators require preservation because they are intended to be consumed by a backend. These operators can contain view and mutation, as they won't be part of the graph after to_backend. If there are still view and mutation ops after to_backend, verification should throw an error. This diff: 1. Removes verification check from _generated_edge_program, which is called by to_edge and to_edge_transform_and_lower 2. Add verification check in to_edge 3. to_edge_transform_and_lower already has a verification check after to_backend; add config.preserve ops there. Reviewed By: metascroy Differential Revision: D78535519
|
This pull request was exported from Phabricator. Differential Revision: D78535519 |
metascroy
approved these changes
Jul 18, 2025
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jul 18, 2025
Summary: Some operators require preservation because they are intended to be consumed by a backend. These operators can contain view and mutation, as they won't be part of the graph after to_backend. If there are still view and mutation ops after to_backend, verification should throw an error. This diff: 1. Removes verification check from _generated_edge_program, which is called by to_edge and to_edge_transform_and_lower 2. Add verification check in to_edge 3. to_edge_transform_and_lower already has a verification check after to_backend; add config.preserve ops there. Remove preserve_ops_view test; after to_edge, there should be no view ops. https://www.internalfb.com/code/fbsource/[f677b61422b9927eabc36d3b15857b06186cf7ef]/fbcode/executorch/exir/program/_program.py?lines=835 Reviewed By: metascroy Differential Revision: D78535519
|
This pull request was exported from Phabricator. Differential Revision: D78535519 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jul 18, 2025
Summary: Some operators require preservation because they are intended to be consumed by a backend. These operators can contain view and mutation, as they won't be part of the graph after to_backend. If there are still view and mutation ops after to_backend, verification should throw an error. This diff: 1. Removes verification check from _generated_edge_program, which is called by to_edge and to_edge_transform_and_lower 2. Add verification check in to_edge 3. to_edge_transform_and_lower already has a verification check after to_backend; add config.preserve ops there. Remove preserve_ops_view test; after to_edge, there should be no view ops. https://www.internalfb.com/code/fbsource/[f677b61422b9927eabc36d3b15857b06186cf7ef]/fbcode/executorch/exir/program/_program.py?lines=835 Reviewed By: metascroy Differential Revision: D78535519
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jul 18, 2025
Summary: Pull Request resolved: pytorch#12630 Some operators require preservation because they are intended to be consumed by a backend. These operators can contain view and mutation, as they won't be part of the graph after to_backend. If there are still view and mutation ops after to_backend, verification should throw an error. This diff: 1. Removes verification check from _generated_edge_program, which is called by to_edge and to_edge_transform_and_lower. 2. to_edge: run verification for aten dialect (before to_edge) and edge dialect (after to_edge). 3. to_edge_transform_and_lower: only run the edge verification. Reviewed By: metascroy Differential Revision: D78535519
|
This pull request was exported from Phabricator. Differential Revision: D78535519 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jul 18, 2025
Summary: Some operators require preservation because they are intended to be consumed by a backend. These operators can contain view and mutation, as they won't be part of the graph after to_backend. If there are still view and mutation ops after to_backend, verification should throw an error. This diff: 1. Removes verification check from _generated_edge_program, which is called by to_edge and to_edge_transform_and_lower. 2. to_edge: run verification for aten dialect (before to_edge) and edge dialect (after to_edge). 3. to_edge_transform_and_lower: only run the edge verification. Reviewed By: metascroy Differential Revision: D78535519
|
This pull request was exported from Phabricator. Differential Revision: D78535519 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jul 21, 2025
…pytorch#12630) Summary: Some operators require preservation because they are intended to be consumed by a backend. These operators can contain view and mutation, as they won't be part of the graph after to_backend. If there are still view and mutation ops after to_backend, verification should throw an error. This diff: 1. Removes verification check from _generated_edge_program, which is called by to_edge and to_edge_transform_and_lower on the aten dialect. 2. to_edge: run verification for aten dialect (before to_edge) and edge dialect (after to_edge). 3. to_edge_transform_and_lower: only run the edge verification. Reviewed By: metascroy Differential Revision: D78535519
|
This pull request was exported from Phabricator. Differential Revision: D78535519 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jul 21, 2025
…pytorch#12630) Summary: Some operators require preservation because they are intended to be consumed by a backend. These operators can contain view and mutation, as they won't be part of the graph after to_backend. If there are still view and mutation ops after to_backend, verification should throw an error. This diff: 1. Removes verification check from _generated_edge_program, which is called by to_edge and to_edge_transform_and_lower on the aten dialect. 2. to_edge: run verification for aten dialect (before to_edge) and edge dialect (after to_edge). 3. to_edge_transform_and_lower: only run the edge verification. Reviewed By: metascroy Differential Revision: D78535519
|
This pull request was exported from Phabricator. Differential Revision: D78535519 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jul 21, 2025
…pytorch#12630) Summary: Pull Request resolved: pytorch#12630 Some operators require preservation because they are intended to be consumed by a backend. These operators can contain view and mutation, as they won't be part of the graph after to_backend. If there are still view and mutation ops after to_backend, verification should throw an error. This diff: 1. Removes verification check from _generated_edge_program, which is called by to_edge and to_edge_transform_and_lower on the aten dialect. 2. to_edge: run verification for aten dialect (before to_edge) and edge dialect (after to_edge). 3. to_edge_transform_and_lower: only run the edge verification. Reviewed By: metascroy Differential Revision: D78535519
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jul 21, 2025
…pytorch#12630) Summary: Some operators require preservation because they are intended to be consumed by a backend. These operators can contain view and mutation, as they won't be part of the graph after to_backend. If there are still view and mutation ops after to_backend, verification should throw an error. This diff: 1. Removes verification check from _generated_edge_program, which is called by to_edge and to_edge_transform_and_lower on the aten dialect. 2. to_edge: run verification for aten dialect (before to_edge) and edge dialect (after to_edge). 3. to_edge_transform_and_lower: only run the edge verification. Reviewed By: metascroy Differential Revision: D78535519
|
This pull request was exported from Phabricator. Differential Revision: D78535519 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jul 21, 2025
…pytorch#12630) Summary: Some operators require preservation because they are intended to be consumed by a backend. These operators can contain view and mutation, as they won't be part of the graph after to_backend. If there are still view and mutation ops after to_backend, verification should throw an error. This diff: 1. Removes verification check from _generated_edge_program, which is called by to_edge and to_edge_transform_and_lower on the aten dialect. 2. to_edge: run verification for aten dialect (before to_edge) and edge dialect (after to_edge). 3. to_edge_transform_and_lower: only run the edge verification. Reviewed By: metascroy Differential Revision: D78535519
|
This pull request was exported from Phabricator. Differential Revision: D78535519 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jul 21, 2025
…pytorch#12630) Summary: Pull Request resolved: pytorch#12630 Some operators require preservation because they are intended to be consumed by a backend. These operators can contain view and mutation, as they won't be part of the graph after to_backend. If there are still view and mutation ops after to_backend, verification should throw an error. This diff: 1. Removes verification check from _generated_edge_program, which is called by to_edge and to_edge_transform_and_lower on the aten dialect. 2. to_edge: run verification for aten dialect (before to_edge) and edge dialect (after to_edge). 3. to_edge_transform_and_lower: only run the edge verification. Reviewed By: metascroy Differential Revision: D78535519
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jul 21, 2025
…pytorch#12630) Summary: Some operators require preservation because they are intended to be consumed by a backend. These operators can contain view and mutation, as they won't be part of the graph after to_backend. If there are still view and mutation ops after to_backend, verification should throw an error. This diff: 1. Removes verification check from _generated_edge_program, which is called by to_edge and to_edge_transform_and_lower on the aten dialect. 2. to_edge: run verification for aten dialect (before to_edge) and edge dialect (after to_edge). 3. to_edge_transform_and_lower: only run the edge verification. Reviewed By: metascroy Differential Revision: D78535519
|
This pull request was exported from Phabricator. Differential Revision: D78535519 |
…pytorch#12630) Summary: Some operators require preservation because they are intended to be consumed by a backend. These operators can contain view and mutation, as they won't be part of the graph after to_backend. If there are still view and mutation ops after to_backend, verification should throw an error. This diff: 1. Removes verification check from _generated_edge_program, which is called by to_edge and to_edge_transform_and_lower on the aten dialect. 2. to_edge: run verification for aten dialect (before to_edge) and edge dialect (after to_edge). 3. to_edge_transform_and_lower: only run the edge verification. Reviewed By: metascroy Differential Revision: D78535519
|
This pull request was exported from Phabricator. Differential Revision: D78535519 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Some operators require preservation because they are intended to be consumed by a backend. These operators can contain view and mutation, as they won't be part of the graph after to_backend.
If there are still view and mutation ops after to_backend, verification should throw an error.
Differential Revision: D78535519