Skip to content

Cmsis #12655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Cmsis #12655

wants to merge 4 commits into from

Conversation

psiddh
Copy link
Contributor

@psiddh psiddh commented Jul 18, 2025

Summary

[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a Fixes #<issue-id> line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.

Test plan

[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.

Summary: Initial CMSS-NN Add Op
f6cc262 
Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 18, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12655

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 14 New Failures, 71 Cancelled Jobs

As of commit f953921 with merge base a1b35e8 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2025
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

digantdesai
digantdesai reviewed Jul 18, 2025
View reviewed changes
backends/cortex_m/ops/op_add.cpp
"dtype %" PRId8 " is not int8 (Char)",
static_cast<int8_t>(dtype));

assert(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be a no-op for a RELEASE CMake build.

digantdesai
digantdesai reviewed Jul 18, 2025
View reviewed changes
backends/cortex_m/passes/replace_quant_nodes_pass.py
@@ -31,6 +31,10 @@ def _is_qualified_int8_node(args) -> bool:
def __init__(self):
super().__init__()
self.op_replacements = {
exir_ops.edge.aten.add.Tensor: {
Copy link
Contributor

@digantdesai digantdesai Jul 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you print your graph before and after this pass to see if this replacement is actually happening?

Copy link
Contributor Author

@psiddh psiddh Jul 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes , for the softmax usecase, I see the following

[ReplaceQuantNodesPass] Operator called: <EdgeOpOverload: aten._softmax.default>: schema = aten::_softmax(Tensor self, int dim, bool half_to_float) -> Tensor, Args: (<executorch.exir.pass_base.ProxyValue object at 0x7fa982bc03a0>, 0, False)
[ReplaceQuantNodesPass] Replacing <EdgeOpOverload: aten._softmax.default>: schema = aten::_softmax(Tensor self, int dim, bool half_to_float) -> Tensor with cortex_m.softmax

digantdesai
digantdesai reviewed Jul 18, 2025
View reviewed changes
runtime/core/named_data_map.h
@@ -27,7 +27,7 @@ namespace ET_RUNTIME_NAMESPACE {
* Interface to access and retrieve data via name.
* See executorch/extension/flat_tensor/ for an example.
*/
class ET_EXPERIMENTAL NamedDataMap {
class NamedDataMap {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accidental?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove it.

@psiddh psiddh force-pushed the cmsis branch 2 times, most recently from 38a5ce1 to 8e16851 Compare July 21, 2025 04:41
Initial draft CMSIS-NN integration (WIP)
eb253fd 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
sidart added 2 commits July 21, 2025 16:55
Remove softmax
b440e82 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Summary: Initial CMSIS-NN custom kernels port (Take pytorch#2)
f953921 
Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai digantdesai left review comments

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 will be requested when the pull request is marked ready for review larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign will be requested when the pull request is marked ready for review kirklandsign is a code owner

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka will be requested when the pull request is marked ready for review JacobSzwejbka is a code owner

@lucylq lucylq Awaiting requested review from lucylq lucylq will be requested when the pull request is marked ready for review lucylq is a code owner

@swolchok swolchok Awaiting requested review from swolchok swolchok will be requested when the pull request is marked ready for review swolchok is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psiddh @digantdesai