-
Notifications
You must be signed in to change notification settings - Fork 645
Add top-level CMake extensions target #12696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12696
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 9 PendingAs of commit b3944b3 with merge base 03f6bcc ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
target_link_libraries(executorch_backends INTERFACE ${_executorch_backends}) | ||
|
||
# A target containing all configured extensions. | ||
add_library(executorch_extensions INTERFACE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please include executorch_backends and executorch_extensions in the install() call alongside executorch and executorch_core so that we don't have to coordinate with the EXPORT PR? that should be enough to get it to work no matter which one lands first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated to install these targets. Because of the order of declarations in the file, I can't directly add to the existing executorch / executorch_core install, as it is above many of the backend declarations. To avoid causing a bunch of merge conflicts by rearranging it, I've added an install for these new targets alone. I can add the export directive once #8954 is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you change an example to use these targets, CI will prevent us from messing it up in the future and give this diff coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated executor_runner to use the top-level backends and extensions targets. I'll update examples with the export changes, as well.
The llama runner and ARM tests are infra failures due to download failures (likely related to the ongoing github incident). |
Add a top level extensions CMake target, which includes all configured extensions. I validate this change by building a simple runner using the executorch_extensions target and verifying that it was able to build and run using the module and tensor extension. Once the changes land in ExecuTorch, this will be long-term validated in executorch-examples CI.
This is done in the context of top-level CMake targets, tracked in #12293.