Fix missing cmake_deps.toml dep from size_test to extension_data_loader #12744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
larryliu0820
approved these changes
Jul 23, 2025
swolchok
added a commit
that referenced
this pull request
Jul 23, 2025
size_test.cpp uses FileDataLoader. Looks like this happens to work currently because of the missing cmake_deps.toml entry that gets fixed in #12744
…t failure for the EXPORT PR [ghstack-poisoned]
…t failure for the EXPORT PR [ghstack-poisoned]
|
yeah this explains why we have this compiled even when the CMake variable was OFF |
Gasoonjia
approved these changes
Jul 24, 2025
|
https://github.com/pytorch/executorch/actions/runs/16502309674/job/46669895289?pr=12744 (test-arm-cortex-m-size-test, zephyr version) looks like a real failure; maybe I fixed it in the wrong PR or something. |
[ghstack-poisoned]
|
I think we're good, jobs I was concerned about have passed. merging. |
Conarnar
pushed a commit
to Conarnar/executorch
that referenced
this pull request
Jul 25, 2025
size_test.cpp uses FileDataLoader. Looks like this happens to work currently because of the missing cmake_deps.toml entry that gets fixed in pytorch#12744
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing deps like this causes executorch_srcs.cmake to just roll the sources into the would-be-depending target, which is bad.