Remove quantized_conv and leave just per tensor variants #13958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13958
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 39 PendingAs of commit 607ebf5 with merge base 879e7ba ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D81649180 |
This PR needs a
|
DrJessop
force-pushed
the
export-D81649180
branch
from
260b20a to
9626af6
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 6, 2025
Summary: As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain. Reviewed By: hsharma35 Differential Revision: D81649180
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 6, 2025
Summary: As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain. Reviewed By: hsharma35 Differential Revision: D81649180
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 6, 2025
Summary: As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain. Reviewed By: hsharma35 Differential Revision: D81649180
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 6, 2025
Summary: As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain. Reviewed By: hsharma35 Differential Revision: D81649180
|
This pull request was exported from Phabricator. Differential Revision: D81649180 |
DrJessop
force-pushed
the
export-D81649180
branch
from
9626af6 to
2db498e
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 6, 2025
Summary: Pull Request resolved: pytorch#13958 As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain. Reviewed By: hsharma35 Differential Revision: D81649180
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 6, 2025
Summary: As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain. Reviewed By: hsharma35 Differential Revision: D81649180
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 6, 2025
Summary: As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain. Reviewed By: hsharma35 Differential Revision: D81649180
DrJessop
force-pushed
the
export-D81649180
branch
from
2db498e to
57d7e3c
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain. Reviewed By: hsharma35 Differential Revision: D81649180
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain. Reviewed By: hsharma35 Differential Revision: D81649180
|
This pull request was exported from Phabricator. Differential Revision: D81649180 |
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: Pull Request resolved: pytorch#13958 As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain. Reviewed By: hsharma35 Differential Revision: D81649180
DrJessop
force-pushed
the
export-D81649180
branch
from
57d7e3c to
2837f46
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain. Reviewed By: hsharma35 Differential Revision: D81649180
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain. Reviewed By: hsharma35 Differential Revision: D81649180
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain. Reviewed By: hsharma35 Differential Revision: D81649180
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain. Reviewed By: hsharma35 Differential Revision: D81649180
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain. Reviewed By: hsharma35 Differential Revision: D81649180
hsharma35
approved these changes
Sep 8, 2025
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain. Reviewed By: hsharma35 Differential Revision: D81649180
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain. Reviewed By: hsharma35 Differential Revision: D81649180
DrJessop
force-pushed
the
export-D81649180
branch
from
2837f46 to
729ff06
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81649180 |
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain. Reviewed By: hsharma35 Differential Revision: D81649180
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain. Reviewed By: hsharma35 Differential Revision: D81649180
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain. Reviewed By: hsharma35 Differential Revision: D81649180
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Sep 8, 2025
Summary: As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain. Reviewed By: hsharma35 Differential Revision: D81649180
Summary: As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain. Reviewed By: hsharma35 Differential Revision: D81649180
DrJessop
force-pushed
the
export-D81649180
branch
from
729ff06 to
607ebf5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81649180 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As discussed offline, there is no need for the non-per-tensor-variants of quantized conv channels first/last. Only per-tensor variants remain.
Differential Revision: D81649180