Skip to content

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Sep 5, 2025

Argmin and argmax are crashing on Core ML. Native crashes are hard to recover from. In the medium term, I'd like to look at using pytest-xdist, which, by nature of process isolation, can recover. But for now, I'm adding a way to skip tests on specific backend flows to allow running the remaining tests. I've also skipped Vulkan float16 and float64 tests, as they crash when using swiftshader (used in the CI for software execution of the Vulkan compute shaders). This should be re-visited in the future.

There is also a little technical debt in the code duplication between operator and model tests. This will also be cleaned up shortly.

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Sep 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13992

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 3 Cancelled Jobs, 7 Pending, 3 Unrelated Failures

As of commit 4a50cab with merge base 6d8583d (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

GregoryComer added a commit that referenced this pull request Sep 5, 2025
…Core ML due to native crashes

ghstack-source-id: 36fbd8a
ghstack-comment-id: 3257282474
Pull-Request: #13992
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 5, 2025
@GregoryComer GregoryComer marked this pull request as ready for review September 5, 2025 07:01
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Sep 5, 2025
…Core ML due to native crashes

ghstack-source-id: 4d163c4
ghstack-comment-id: 3257282474
Pull-Request: #13992
@GregoryComer GregoryComer changed the title [Backend Tester] Add flow-specific skipped tests, skip argmin/max on Core ML due to native crashes [Backend Tester] Add flow-specific skipped tests, skip argmin/max on Core ML due to native crashes, float16/64 on Vulkan Sep 5, 2025
@pytorch-bot pytorch-bot bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Sep 5, 2025
[ghstack-poisoned]
GregoryComer and others added 2 commits September 10, 2025 23:22
[ghstack-poisoned]
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/nightly CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant