-
Couldn't load subscription status.
- Fork 700
llm/custom_ops: follow test code conventions #15375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary: Rename Test Suites in `test_sdpa_with_kv_cache` to follow internal tooling conventions and make test target static listable. Previously, some of the Test Suites in the modified test file did not satisfy the condition: * Test Suite's name must contain `Test` This diff makes it so that the Test Suites follow the expected conventions. ### Benefits Following the conventions grants the test targets: * Faster test listing * Better dev experience in VSCode Differential Revision: D85428922
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15375
Note: Links to docs will display an error until the docs builds have been completed. ❌ 8 New Failures, 2 Unrelated FailuresAs of commit 7fed498 with merge base de56c81 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@gpires-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85428922. |
This PR needs a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure the Github CI is green before merging. Stamping to unblock. Thanks.
Summary:
Rename Test Suites in
test_sdpa_with_kv_cacheto follow internal tooling conventions and make test target static listable.Previously, some of the Test Suites in the modified test file did not satisfy the condition:
TestThis diff makes it so that the Test Suites follow the expected conventions.
Benefits
Following the conventions grants the test targets:
Differential Revision: D85428922