Fix double-promotion in rsqrt for reduced-precision types#16221
Open
perheld wants to merge 1 commit intopytorch:mainfrom
Open
Fix double-promotion in rsqrt for reduced-precision types#16221perheld wants to merge 1 commit intopytorch:mainfrom
perheld wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16221
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 4 Unrelated FailuresAs of commit 128e2a8 with merge base cdc2701 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Keep the bfloat16/fp16 rsqrt helper in float precision so Zephyr’s -Wdouble-promotion (treated as an error) no longer fires when ExecuTorch is built for Cortex-M targets. Signed-off-by: per.held@arm.com Change-Id: I8fbcc99d8aebac67c4164f2ad502e9b3081386b4
1451366 to
128e2a8
Compare
Collaborator
Author
|
@digantdesai is c10 something that is copied from pytorch and needs fixing upstream there if there is a needed change? |
Collaborator
|
Hi @SS-JIA / @swolchok is this something we want to do or if from PyTorch maybe we rather not touch it? And if fixed maybe this can be removed from the file:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the bfloat16/fp16 rsqrt helper in float precision so Zephyr’s -Wdouble-promotion (treated as an error) no longer fires when ExecuTorch is built for Cortex-M targets.
Signed-off-by: per.held@arm.com
Change-Id: I8fbcc99d8aebac67c4164f2ad502e9b3081386b4
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai