Update more passes to use new pass interface/correctly set their modified bits #16228
+529
−307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16228
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 18b57e9 with merge base 7815c38 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
DrJessop
force-pushed
the
export-D87898571
branch
from
02ca522 to
08bf060
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Dec 12, 2025
…fied bits (pytorch#16228) Summary: Update - SinkOpsCloserToUsePass - HoistOpsCloserToDefPass - PostponePermuteOpBelowSqueezeOrUnsqueezeLikeView - SimplifySliceOpPass - BindOptionalArgsPass - ReplaceConstantPadWithTuringExtendPass to either use new pass interface (which is more efficient/correctly sets modified bit) or just correctly set modified bit if doesn't fit the interface well. Differential Revision: D87898571
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Dec 12, 2025
…fied bits (pytorch#16228) Summary: Update - SinkOpsCloserToUsePass - HoistOpsCloserToDefPass - PostponePermuteOpBelowSqueezeOrUnsqueezeLikeView - SimplifySliceOpPass - BindOptionalArgsPass - ReplaceConstantPadWithTuringExtendPass to either use new pass interface (which is more efficient/correctly sets modified bit) or just correctly set modified bit if doesn't fit the interface well. Differential Revision: D87898571
DrJessop
force-pushed
the
export-D87898571
branch
from
08bf060 to
47819db
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Dec 12, 2025
…fied bits (pytorch#16228) Summary: Update - SinkOpsCloserToUsePass - HoistOpsCloserToDefPass - PostponePermuteOpBelowSqueezeOrUnsqueezeLikeView - SimplifySliceOpPass - BindOptionalArgsPass - ReplaceConstantPadWithTuringExtendPass to either use new pass interface (which is more efficient/correctly sets modified bit) or just correctly set modified bit if doesn't fit the interface well. Differential Revision: D87898571
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Dec 12, 2025
…fied bits (pytorch#16228) Summary: Update - SinkOpsCloserToUsePass - HoistOpsCloserToDefPass - PostponePermuteOpBelowSqueezeOrUnsqueezeLikeView - SimplifySliceOpPass - BindOptionalArgsPass - ReplaceConstantPadWithTuringExtendPass to either use new pass interface (which is more efficient/correctly sets modified bit) or just correctly set modified bit if doesn't fit the interface well. Differential Revision: D87898571
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Dec 12, 2025
…fied bits (pytorch#16228) Summary: Update - SinkOpsCloserToUsePass - HoistOpsCloserToDefPass - PostponePermuteOpBelowSqueezeOrUnsqueezeLikeView - SimplifySliceOpPass - BindOptionalArgsPass - ReplaceConstantPadWithTuringExtendPass to either use new pass interface (which is more efficient/correctly sets modified bit) or just correctly set modified bit if doesn't fit the interface well. Differential Revision: D87898571
hsharma35
approved these changes
Dec 21, 2025
DrJessop
force-pushed
the
export-D87898571
branch
from
47819db to
b7a1e0e
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Jan 8, 2026
…fied bits (pytorch#16228) Summary: Update - SinkOpsCloserToUsePass - HoistOpsCloserToDefPass - PostponePermuteOpBelowSqueezeOrUnsqueezeLikeView - SimplifySliceOpPass - BindOptionalArgsPass - ReplaceConstantPadWithTuringExtendPass to either use new pass interface (which is more efficient/correctly sets modified bit) or just correctly set modified bit if doesn't fit the interface well. Reviewed By: hsharma35 Differential Revision: D87898571
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Jan 8, 2026
…fied bits (pytorch#16228) Summary: Update - SinkOpsCloserToUsePass - HoistOpsCloserToDefPass - PostponePermuteOpBelowSqueezeOrUnsqueezeLikeView - SimplifySliceOpPass - BindOptionalArgsPass - ReplaceConstantPadWithTuringExtendPass to either use new pass interface (which is more efficient/correctly sets modified bit) or just correctly set modified bit if doesn't fit the interface well. Reviewed By: hsharma35 Differential Revision: D87898571
DrJessop
force-pushed
the
export-D87898571
branch
from
b7a1e0e to
8838d3b
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Jan 9, 2026
…fied bits (pytorch#16228) Summary: Update - SinkOpsCloserToUsePass - HoistOpsCloserToDefPass - PostponePermuteOpBelowSqueezeOrUnsqueezeLikeView - SimplifySliceOpPass - BindOptionalArgsPass - ReplaceConstantPadWithTuringExtendPass to either use new pass interface (which is more efficient/correctly sets modified bit) or just correctly set modified bit if doesn't fit the interface well. Reviewed By: hsharma35 Differential Revision: D87898571
DrJessop
force-pushed
the
export-D87898571
branch
from
8838d3b to
1613e37
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Jan 9, 2026
…fied bits (pytorch#16228) Summary: Update - SinkOpsCloserToUsePass - HoistOpsCloserToDefPass - PostponePermuteOpBelowSqueezeOrUnsqueezeLikeView - SimplifySliceOpPass - BindOptionalArgsPass - ReplaceConstantPadWithTuringExtendPass to either use new pass interface (which is more efficient/correctly sets modified bit) or just correctly set modified bit if doesn't fit the interface well. Reviewed By: hsharma35 Differential Revision: D87898571
DrJessop
force-pushed
the
export-D87898571
branch
from
1613e37 to
96b6bd4
Compare
…fied bits (pytorch#16228) Summary: Update - SinkOpsCloserToUsePass - HoistOpsCloserToDefPass - PostponePermuteOpBelowSqueezeOrUnsqueezeLikeView - SimplifySliceOpPass - BindOptionalArgsPass - ReplaceConstantPadWithTuringExtendPass to either use new pass interface (which is more efficient/correctly sets modified bit) or just correctly set modified bit if doesn't fit the interface well. Reviewed By: hsharma35 Differential Revision: D87898571
DrJessop
force-pushed
the
export-D87898571
branch
from
96b6bd4 to
18b57e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Update
to either use new pass interface (which is more efficient/correctly sets modified bit) or just correctly set modified bit if doesn't fit the interface well.
Differential Revision: D87898571