Skip to content

Use explicit unique targets for vision operators#17527

Open
mcremon-meta wants to merge 3 commits intomainfrom
export-D93537671
Open

Use explicit unique targets for vision operators#17527
mcremon-meta wants to merge 3 commits intomainfrom
export-D93537671

Conversation

@mcremon-meta
Copy link
Contributor

Summary:
Use explicit, unique cxx_library targets for each vision operator, following the same pattern used by generic operators.

Each operator now has its own named target (e.g., op_add, op_softmax, op_quantized_conv2d_nchw_out) with specific dependencies, making the build configuration more maintainable and explicit.

Added # buildifier: keep sorted annotation to COMMON_DEPS to enforce alphabetical ordering via the linter.

Differential Revision: D93537671

Summary:

Use explicit, unique cxx_library targets for each hifi4 operator, following the same pattern used by generic operators.

Each operator now has its own named target (e.g., `op_add`, `op_softmax`, `op_quantized_conv2d_nchw_out`) with specific dependencies, making the build configuration more maintainable and explicit.

Added `# buildifier: keep sorted` annotation to COMMON_DEPS to enforce alphabetical ordering via the linter.

Differential Revision: D93517711
Summary:

Use explicit, unique cxx_library targets for each fusion_g3 operator, following the same pattern used by generic and hifi operators.

Each operator now has its own named target (e.g., `op_add`, `op_softmax`, `op_dequantize`) with specific dependencies, making the build configuration more maintainable and explicit.

Added `# buildifier: keep sorted` annotation to COMMON_DEPS to enforce alphabetical ordering via the linter.

Differential Revision: D93520739
Summary:
Use explicit, unique cxx_library targets for each vision operator, following the same pattern used by generic operators.

Each operator now has its own named target (e.g., `op_add`, `op_softmax`, `op_quantized_conv2d_nchw_out`) with specific dependencies, making the build configuration more maintainable and explicit.

Added `# buildifier: keep sorted` annotation to COMMON_DEPS to enforce alphabetical ordering via the linter.

Differential Revision: D93537671
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 18, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17527

Note: Links to docs will display an error until the docs builds have been completed.

❌ 34 New Failures, 15 Unrelated Failures

As of commit 225de4d with merge base cfbc158 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 18, 2026
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Feb 18, 2026

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93537671.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments