3/x: Wire LoadBackendOptionsMap through Program and Method#17531
3/x: Wire LoadBackendOptionsMap through Program and Method#17531metascroy wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17531
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New Failures, 31 PendingAs of commit 20af563 with merge base 0c87468 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@metascroy has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92461088. |
larryliu0820
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This PR needs a
|
34d49a0 to
df336cf
Compare
…7531) Summary: This diff wires the `LoadBackendOptionsMap` through the executor layer, connecting `Program::load_method()` and `Method` to accept and route backend options to delegates. Key changes: - `Program::load_method()` now accepts optional `LoadBackendOptionsMap*` parameter - `Method` stores reference to the options map and looks up options by backend ID - When initializing delegates, the runtime queries the map for backend-specific options and passes them to `BackendInitContext` This enables the end-to-end flow: ``` Module::load(method_name, options_map) → Program::load_method(..., options_map) → Method initialization → Backend delegate init with runtime_specs from options_map ``` Reviewed By: larryliu0820 Differential Revision: D92461088
…7531) Summary: This diff wires the `LoadBackendOptionsMap` through the executor layer, connecting `Program::load_method()` and `Method` to accept and route backend options to delegates. Key changes: - `Program::load_method()` now accepts optional `LoadBackendOptionsMap*` parameter - `Method` stores reference to the options map and looks up options by backend ID - When initializing delegates, the runtime queries the map for backend-specific options and passes them to `BackendInitContext` This enables the end-to-end flow: ``` Module::load(method_name, options_map) → Program::load_method(..., options_map) → Method initialization → Backend delegate init with runtime_specs from options_map ``` Reviewed By: larryliu0820 Differential Revision: D92461088
df336cf to
6e0b9cc
Compare
…7531) Summary: This diff wires the `LoadBackendOptionsMap` through the executor layer, connecting `Program::load_method()` and `Method` to accept and route backend options to delegates. Key changes: - `Program::load_method()` now accepts optional `LoadBackendOptionsMap*` parameter - `Method` stores reference to the options map and looks up options by backend ID - When initializing delegates, the runtime queries the map for backend-specific options and passes them to `BackendInitContext` This enables the end-to-end flow: ``` Module::load(method_name, options_map) → Program::load_method(..., options_map) → Method initialization → Backend delegate init with runtime_specs from options_map ``` Reviewed By: larryliu0820 Differential Revision: D92461088
6e0b9cc to
2d10361
Compare
…7531) Summary: This diff wires the `LoadBackendOptionsMap` through the executor layer, connecting `Program::load_method()` and `Method` to accept and route backend options to delegates. Key changes: - `Program::load_method()` now accepts optional `LoadBackendOptionsMap*` parameter - `Method` stores reference to the options map and looks up options by backend ID - When initializing delegates, the runtime queries the map for backend-specific options and passes them to `BackendInitContext` This enables the end-to-end flow: ``` Module::load(method_name, options_map) → Program::load_method(..., options_map) → Method initialization → Backend delegate init with runtime_specs from options_map ``` Reviewed By: larryliu0820 Differential Revision: D92461088
2d10361 to
98d350d
Compare
…7531) Summary: This diff wires the `LoadBackendOptionsMap` through the executor layer, connecting `Program::load_method()` and `Method` to accept and route backend options to delegates. Key changes: - `Program::load_method()` now accepts optional `LoadBackendOptionsMap*` parameter - `Method` stores reference to the options map and looks up options by backend ID - When initializing delegates, the runtime queries the map for backend-specific options and passes them to `BackendInitContext` This enables the end-to-end flow: ``` Module::load(method_name, options_map) → Program::load_method(..., options_map) → Method initialization → Backend delegate init with runtime_specs from options_map ``` Reviewed By: larryliu0820 Differential Revision: D92461088
98d350d to
20af563
Compare
Summary:
This diff wires the
LoadBackendOptionsMapthrough the executor layer, connectingProgram::load_method()andMethodto accept and route backend options to delegates.Key changes:
Program::load_method()now accepts optionalLoadBackendOptionsMap*parameterMethodstores reference to the options map and looks up options by backend IDBackendInitContextThis enables the end-to-end flow:
Reviewed By: larryliu0820
Differential Revision: D92461088