Skip to content

Update torch pin nightly to 20260310#18187

Open
mergennachin wants to merge 1 commit intomainfrom
mergnenachin/update_pin
Open

Update torch pin nightly to 20260310#18187
mergennachin wants to merge 1 commit intomainfrom
mergnenachin/update_pin

Conversation

@mergennachin
Copy link
Contributor

@mergennachin mergennachin commented Mar 15, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 15, 2026 20:48
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 15, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18187

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Awaiting Approval, 90 New Failures, 46 Cancelled Jobs

As of commit 1760e4d with merge base abc0237 (image):

AWAITING APPROVAL - The following workflow needs approval before CI can run:

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 15, 2026
@github-actions
Copy link

github-actions bot commented Mar 15, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot AI reviewed Mar 15, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s PyTorch/nightly pins and includes compiler-conditional workarounds for toolchain/regression issues (GCC/C++ standard and ROCm/HIP complex math).

Changes:

  • Bumped PyTorch and nightly version pins (including torchcodec) to dev20260310 and updated CI commit pin.
  • Tweaked C10_RETURN_MOVE_IF_OLD_COMPILER detection to consider the C++ standard version for GCC.
  • Added a HIP-specific pow(complex<float>, complex<float>) implementation using FMA-oriented complex multiplication (workaround for ROCm regression).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
torch_pin.py Updates pinned Torch and nightly version strings.
runtime/core/portable_type/c10/torch/headeronly/macros/Macros.h Adjusts “old compiler” macro condition to include C++ standard gating for GCC.
runtime/core/portable_type/c10/c10/util/complex_math.h Adds HIP-only complex pow specialization using an FMA-based multiply path.
examples/models/moshi/mimi/install_requirements.sh Updates torchcodec nightly pin used by the example install script.
.ci/scripts/test_model_e2e.sh Updates torchcodec nightly pin for whisper/voxtral e2e CI path.
.ci/docker/ci_commit_pins/pytorch.txt Updates the pinned PyTorch commit hash used by CI docker/pins.
Comments suppressed due to low confidence (1)

runtime/core/portable_type/c10/torch/headeronly/macros/Macros.h:1

  • The condition now depends on both the compiler version and the C++ standard level (__cplusplus < 202002L), but the comment only describes compiler age. Update the comment to document why C++20 changes the workaround behavior (e.g., due to language rules/guarantees or a known GCC issue that only applies before C++20).
#ifndef C10_MACROS_MACROS_H_

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@mergennachin mergennachin had a problem deploying to upload-benchmark-results March 15, 2026 21:36 — with GitHub Actions Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@manuelcandales manuelcandales Awaiting requested review from manuelcandales

@kirklandsign kirklandsign Awaiting requested review from kirklandsign

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mergennachin