Skip to content

Add helion prefix to Triton kernel name #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
Merged

Add helion prefix to Triton kernel name #486

merged 1 commit into from
Aug 12, 2025

Conversation

yf225
Copy link
Contributor

@yf225 yf225 commented Aug 11, 2025

This makes it easier for data science team to tell which Triton kernels are written by user vs. generated by Helion.

@yf225 yf225 requested review from jansel and oulgen August 11, 2025 23:48
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 11, 2025
@@ -53,7 +53,9 @@ def __init__(self, func: HostFunction, config: Config) -> None:
self.next_else_block: list[ast.AST] | None = None

# Now create device function and initialize CodegenInterface
self.device_function = DeviceFunction(f"_{func.name}_kernel", config, self)
self.device_function = DeviceFunction(
f"_helion_{func.name}_kernel", config, self
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably dont need kernel suffix anymore

Copy link
Contributor

@jansel jansel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the _kernel

@yf225 yf225 merged commit 3713241 into main Aug 12, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants