Allow Windows x64 wheels to be built with python -m build
#6888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NicolasHug is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
NicolasHug
changed the title
python -m build
atalman
approved these changes
Aug 4, 2025
There was a problem hiding this comment.
Looks good! Should we also add test build for it ? Similar to https://github.com/pytorch/test-infra/blob/main/.github/workflows/test_build_wheels_windows_with_cuda.yml
|
Thanks for the review, I'll merge and will submit the test as a follow-up now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
build-platformandbuild-commandoptions to the windows wheel building scripts. These options are already present for both the linux and macos wheel building scripts. We need this for adding Windows support to torchcodec since we build wheels withpython -m build, not withpython setup.py.The corresponding PR in torchcodec is pytorch/torchcodec#753, which is green, so this seems to be working as expected.