Wdvr/clouddevservers #7007
Draft
Wdvr/clouddevservers #7007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
meta-cla
bot
added
the
CLA Signed
Signed-off-by: Eli Uriegas <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a comprehensive GPU development server infrastructure using AWS EKS and Terraform, designed to provide managed GPU resources for PyTorch development. The system uses Kubernetes for container orchestration and includes a complete reservation system with SQS queuing, Lambda processing, and a CLI tool for user interaction.
Key Changes:
- Infrastructure as Code: Complete Terraform configuration for AWS EKS cluster with GPU node groups supporting multiple GPU types (T4, A100, H100, H200)
- Reservation System: SQS-based queuing system with Lambda functions for processing reservations, managing expiry, and tracking availability
- CLI Tool: Python-based CLI for making GPU reservations, checking status, and connecting to development environments
Reviewed Changes
Copilot reviewed 37 out of 40 changed files in this pull request and generated 2 comments.
:
| File | Description |
|---|---|
| terraform-gpu-devservers/ | Complete Terraform infrastructure for EKS cluster, Lambda functions, DynamoDB tables, and networking |
| cli-tools/gpu-dev-cli/ | Python CLI tool with Poetry configuration for managing GPU reservations |
Files not reviewed (1)
- terraform-gpu-devservers/.terraform.lock.hcl: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| spec: | ||
| cluster: | ||
| name: ${cluster_name} | ||
| apiServerEndpoint: https://F2607FF61905D0D2D265A7125F34C8CD.gr7.us-east-2.eks.amazonaws.com |
There was a problem hiding this comment.
Hard-coded API server endpoint exposes sensitive cluster information and makes the configuration inflexible. This should be templated using variables to allow dynamic cluster configuration.
Suggested change
| apiServerEndpoint: https://F2607FF61905D0D2D265A7125F34C8CD.gr7.us-east-2.eks.amazonaws.com | |
| apiServerEndpoint: ${api_server_endpoint} |
Copilot uses AI. Check for mistakes.
| cluster: | ||
| name: ${cluster_name} | ||
| apiServerEndpoint: https://F2607FF61905D0D2D265A7125F34C8CD.gr7.us-east-2.eks.amazonaws.com | ||
| certificateAuthority: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSURCVENDQWUyZ0F3SUJBZ0lJQTlJQTVVWDJybk13RFFZSktvWklodmNOQVFFTEJRQXdGVEVUTUJFR0ExVUUKQXhNS2EzVmlaWEp1WlhSbGN6QWVGdzB5TlRBNE1UTXlNakl3TVROYUZ3MHpOVEE0TVRFeU1qSTFNVE5hTUJVeApFekFSQmdOVkJBTVRDbXQxWW1WeWJtVjBaWE13Z2dFaU1BMEdDU3FHU0liM0RRRUJBUVVBQTRJQkR3QXdnZ0VLCkFvSUJBUUMxQVNDU0hBWkk5SnFaOHJlUU1LWjNPbXBYc0lXOTlCUUQ3Tmpqb3FlTWtKdFBYMEtRdmtjSFFEbXgKdC9QZlZSTDhBZGEydGxFKzZxVmFqQmE4ODhlelBwc1p6V2NNeDgrcUFxQ29qRWZ5K0EvTXhqYjRxK0RwMTNZYgp3bnp3MGFpbDF5cXBsdTBHSkQ4N2d5WjI0bjZQd1IxVENZTHVRTVl4dTdwTENJbE04dkRweHhlQ0xJVUVjSEh5CjFXWHdDblE0b0dEbXN4RmxjVE01MW1DWVRncGtnM0h2ZWd0ZDN4N3ZsOE40anV1VUNFY0ZBd1AwMFdKV2MxTlIKT2dZd0xEemxDeXo4aFBDUlFsbXMyVjVSQll6RHNvbldCU3NqWFdXZWUxZnIwR3p3bEhLclpmc0V1ZFNINm9UMgpmNStBbUVYWVpaTmlIa3RQcElVOEw3ZmtOYnE5QWdNQkFBR2pXVEJYTUE0R0ExVWREd0VCL3dRRUF3SUNwREFQCkJnTlZIUk1CQWY4RUJUQURBUUgvTUIwR0ExVWREZ1FXQkJTQ1JsQ3pXVlJSTHFZcFRnQWlLY3NkMHJFSStEQVYKQmdOVkhSRUVEakFNZ2dwcmRXSmxjbTVsZEdWek1BMEdDU3FHU0liM0RRRUJDd1VBQTRJQkFRQk1qNDBDMUk2ZgpZNUdpTVpySGZVOU1TOUpuRnlCZit6M3dqeDBSUTFReEhaUjJqNHpSSytzKzVSWnNlQUNuZlVVRHp4dTBQRlJSCkdmUEg5b3ZlS24wSTNLa3pYbHJEZHI1d1RtQkF0bE1CRXJtU3pncEJySGV5WU41SmVuWW9IRFk2dnM1RFAvcGoKWXdDbG03TEdnSHNkdzdLVFMrVGxIbzlRWVdmQmxTN09GUnpQdGkxWWNsdnE3NkgwenZJbkhGSHJla2RmKzg1NQpvWkhRUkVPbUs5Y25Lem5COTJqMFcwRUh6d0UzbE1MdllZR0ZTTVZvUHhWeEE0NXg1WTFDcE9Bdks0c2ZLTkN3CmhGMkNLSzVpMkI1ODZhNUhkeENjWkFVd0R0VkJiZDlyRXB6czNiK3RyaXIzb291NytoKzBvNWFvOGxSK0NjSXUKazJXSkFHaEJ6OWxsCi0tLS0tRU5EIENFUlRJRklDQVRFLS0tLS0K |
There was a problem hiding this comment.
Hard-coded certificate authority data exposes sensitive cluster certificates and makes the configuration inflexible. This should be templated using variables to allow dynamic cluster configuration.
Suggested change
| certificateAuthority: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSURCVENDQWUyZ0F3SUJBZ0lJQTlJQTVVWDJybk13RFFZSktvWklodmNOQVFFTEJRQXdGVEVUTUJFR0ExVUUKQXhNS2EzVmlaWEp1WlhSbGN6QWVGdzB5TlRBNE1UTXlNakl3TVROYUZ3MHpOVEE0TVRFeU1qSTFNVE5hTUJVeApFekFSQmdOVkJBTVRDbXQxWW1WeWJtVjBaWE13Z2dFaU1BMEdDU3FHU0liM0RRRUJBUVVBQTRJQkR3QXdnZ0VLCkFvSUJBUUMxQVNDU0hBWkk5SnFaOHJlUU1LWjNPbXBYc0lXOTlCUUQ3Tmpqb3FlTWtKdFBYMEtRdmtjSFFEbXgKdC9QZlZSTDhBZGEydGxFKzZxVmFqQmE4ODhlelBwc1p6V2NNeDgrcUFxQ29qRWZ5K0EvTXhqYjRxK0RwMTNZYgp3bnp3MGFpbDF5cXBsdTBHSkQ4N2d5WjI0bjZQd1IxVENZTHVRTVl4dTdwTENJbE04dkRweHhlQ0xJVUVjSEh5CjFXWHdDblE0b0dEbXN4RmxjVE01MW1DWVRncGtnM0h2ZWd0ZDN4N3ZsOE40anV1VUNFY0ZBd1AwMFdKV2MxTlIKT2dZd0xEemxDeXo4aFBDUlFsbXMyVjVSQll6RHNvbldCU3NqWFdXZWUxZnIwR3p3bEhLclpmc0V1ZFNINm9UMgpmNStBbUVYWVpaTmlIa3RQcElVOEw3ZmtOYnE5QWdNQkFBR2pXVEJYTUE0R0ExVWREd0VCL3dRRUF3SUNwREFQCkJnTlZIUk1CQWY4RUJUQURBUUgvTUIwR0ExVWREZ1FXQkJTQ1JsQ3pXVlJSTHFZcFRnQWlLY3NkMHJFSStEQVYKQmdOVkhSRUVEakFNZ2dwcmRXSmxjbTVsZEdWek1BMEdDU3FHU0liM0RRRUJDd1VBQTRJQkFRQk1qNDBDMUk2ZgpZNUdpTVpySGZVOU1TOUpuRnlCZit6M3dqeDBSUTFReEhaUjJqNHpSSytzKzVSWnNlQUNuZlVVRHp4dTBQRlJSCkdmUEg5b3ZlS24wSTNLa3pYbHJEZHI1d1RtQkF0bE1CRXJtU3pncEJySGV5WU41SmVuWW9IRFk2dnM1RFAvcGoKWXdDbG03TEdnSHNkdzdLVFMrVGxIbzlRWVdmQmxTN09GUnpQdGkxWWNsdnE3NkgwenZJbkhGSHJla2RmKzg1NQpvWkhRUkVPbUs5Y25Lem5COTJqMFcwRUh6d0UzbE1MdllZR0ZTTVZvUHhWeEE0NXg1WTFDcE9Bdks0c2ZLTkN3CmhGMkNLSzVpMkI1ODZhNUhkeENjWkFVd0R0VkJiZDlyRXB6czNiK3RyaXIzb291NytoKzBvNWFvOGxSK0NjSXUKazJXSkFHaEJ6OWxsCi0tLS0tRU5EIENFUlRJRklDQVRFLS0tLS0K | |
| apiServerEndpoint: https://${api_server_endpoint} | |
| certificateAuthority: ${certificate_authority_data} |
Copilot uses AI. Check for mistakes.
|
@wdvr is the idea to have a single EKS cluster for devs to share? where will this cluster be deployed to (only Meta, or both Meta & LF AWS Accounts)? |
Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
This actually needs to be more permissive since subagents typically rely on haiku rather than sonnet for cost considerations Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.