add test coverage for loading state dict from cpu for EBC sharding #3362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D82002643 |
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Sep 9, 2025
…ytorch#3362) Summary: # context * OSS CI [test is failing](https://github.com/pytorch/torchrec/actions/runs/17565037476/job/49890092618) due to incorrect sharded EBC weights, which further comes from a recent change D80547120, where the eager-mode EBC is on CPU * the `load_state_dict` is skipped from [day-1](https://www.internalfb.com/diff/D46653763?dst_version_fbid=803682924606242&transaction_fbid=6359829970773670) Differential Revision: D82002643
Summary: # context * the proposal order might vary on different rank in [github action](https://github.com/pytorch/torchrec/actions/runs/17589918113/job/49967902728?fbclid=IwY2xjawMtaPxleHRuA2FlbQIxMQABHqSimhEWaKNU_G5SH_R2nioBbN7otIqoM1RDmlcjIZwB37M0cNWPEiOERRv1_aem_bhDL2MD4niEtgGMZrytbJQ) * skip this test * error log: P1939004930 * order [comparison](https://www.internalfb.com/intern/diffing/?paste_number=1939241286) {F1981848607, width=300} * ref: D76303748 Reviewed By: aporialiao Differential Revision: D82031515
…ytorch#3362) Summary: # context * OSS CI [test is failing](https://github.com/pytorch/torchrec/actions/runs/17565037476/job/49890092618) due to incorrect sharded EBC weights, which further comes from a recent change D80547120, where the eager-mode EBC is on CPU * the `load_state_dict` is skipped from [day-1](https://www.internalfb.com/diff/D46653763?dst_version_fbid=803682924606242&transaction_fbid=6359829970773670) Differential Revision: D82002643
TroyGarden
force-pushed
the
export-D82002643
branch
from
3d5a9f6 to
6cf372b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D82002643 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
context
load_state_dictis skipped from day-1Differential Revision: D82002643