Skip to content

Bump tolerances for per_sample_grads tutorial #3487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 30, 2025
Merged

Bump tolerances for per_sample_grads tutorial #3487

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6facada
[DO NOT MERGE] 2.8 RC Test
svekars Jul 14, 2025
251bfe5
Update .jenkins/build.sh
svekars Jul 14, 2025
20ee808
Update .jenkins/build.sh
svekars Jul 14, 2025
bfb17d5
Update build.sh
svekars Jul 14, 2025
eed36cb
Update .jenkins/build.sh
svekars Jul 14, 2025
d18ba11
Update dqn_with_rnn_tutorial.py
sekyondaMeta Jul 15, 2025
5d53ab4
Merge branch 'main' into RC-TEST-2.8
sekyondaMeta Jul 15, 2025
c0d8387
Update dqn_with_rnn_tutorial.py
sekyondaMeta Jul 15, 2025
13572ee
Update
svekars Jul 15, 2025
c391f15
Merge branch 'main' into RC-TEST-2.8
sekyondaMeta Jul 16, 2025
caa0094
Update dqn_with_rnn_tutorial.py
sekyondaMeta Jul 16, 2025
1b1aa8f
Bump tolerances for per_sample_grads tutorial
mikaylagawarecki Jul 23, 2025
3825480
Merge branch 'main' into bump_tol
sekyondaMeta Jul 30, 2025
f62e4d3
Update build.sh
sekyondaMeta Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion intermediate_source/per_sample_grads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ def compute_loss(params, buffers, sample, target):
# results of hand processing each one individually:

for per_sample_grad, ft_per_sample_grad in zip(per_sample_grads, ft_per_sample_grads.values()):
assert torch.allclose(per_sample_grad, ft_per_sample_grad, atol=3e-3, rtol=1e-5)
assert torch.allclose(per_sample_grad, ft_per_sample_grad, atol=1.2e-1, rtol=1e-5)

######################################################################
# A quick note: there are limitations around what types of functions can be
Expand Down