Error Handling: replace XLA_CHECK_OK() with status functions.
#9457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysiraichi
force-pushed
the
ysiraichi/replace-xla-check-ok
branch
from
6ec6a94 to
6b12898
Compare
ysiraichi
force-pushed
the
ysiraichi/replace-xla-check-ok
branch
from
6b12898 to
7d13b31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
XLA_CHECK_OK()macro withMaybeThrow()andGetValueOrThrow()functionsXLA_CHECK*()withABSL_CHECK*()macro calls.These changes improve error handling by not crashing when non-ok status values are returned (1), and by crashing on internal errors (2).