Skip to content

Implement XLAShardedTensor._spec and test #9488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 24, 2025

Conversation

aws-cph
Copy link
Contributor

@aws-cph aws-cph commented Jul 17, 2025

Implementing and adding tests for XLAShardedTensor._spec in regards to #9418.

@aws-cph aws-cph force-pushed the aws-cph_dtensor_spec branch 2 times, most recently from 78a5639 to 4dd06ad Compare July 18, 2025 22:08
@aws-cph aws-cph force-pushed the aws-cph_dtensor_spec branch from 3ab7296 to 16f02a4 Compare July 22, 2025 18:43
@aws-cph aws-cph force-pushed the aws-cph_dtensor_spec branch from 1d2aa97 to 213efc6 Compare July 23, 2025 18:21
@aws-cph aws-cph force-pushed the aws-cph_dtensor_spec branch from 213efc6 to 25147a2 Compare July 23, 2025 21:48
@aws-cph aws-cph force-pushed the aws-cph_dtensor_spec branch from 25147a2 to 5a61b1d Compare July 23, 2025 21:49
@aws-cph aws-cph requested a review from bfolie July 23, 2025 21:49
Copy link
Collaborator

@bfolie bfolie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I have one suggestion about test structure but it's non-blocking

@jeffhataws jeffhataws merged commit ca47198 into pytorch:master Jul 24, 2025
23 of 24 checks passed
@aws-cph aws-cph deleted the aws-cph_dtensor_spec branch July 24, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants