Change Vec to iterators and clone to borrow #23
Merged
+51
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I changed the name to this: solve_scaled_odgp_with_parity_k_ne_0 Because the zero branch returned the wrong type. But it is never called with k=0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes functions so that they return iterators, rather than
Vec.It is in draft mode because I need to convert a few more functions.
I converted these from
Vecto iterators:I changed the name of the latter to this:
solve_scaled_odgp_with_parity_k_ne_0Because the zero branch returned the wrong type. But it is never called with k=0 anyway.
I replaced some
Vecs with iterators insolve_tdgp.I changed several clones to borrow, an added on method to support one of these.