Skip to content

CMake: fix missing quotes when generating deploy cmake scripts #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Joker-Principal
Copy link

The generated deploy scripts ${CMAKE_BINARY_DIR}/.qt/QtDeployTargets.cmake will contain:

set(__QT_DEPLOY_TARGET_MyTarget_FILE Absolute Path Maybe With Space/MyTarget.dll)
set(__QT_DEPLOY_TARGET_MyTarget_TYPE SHARED_LIBRARY)
set(__QT_DEPLOY_TARGET_MyTarget_RUNTIME_DLLS Absolute Path Maybe With Space/RUNTIME_DLLS.dll)
...

which cause errors because of missing quotes with path

Copy link

cla-assistant bot commented Jul 26, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Jul 26, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Joker seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Joker-Principal Joker-Principal marked this pull request as draft July 29, 2025 15:35
@Joker-Principal Joker-Principal marked this pull request as ready for review July 29, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant