tools: move configure-repo config to JSON - #119
Closed
Simon Beaudoin (simonbeaudoin0935) wants to merge 1 commit into
Closed
tools: move configure-repo config to JSON#119Simon Beaudoin (simonbeaudoin0935) wants to merge 1 commit into
Simon Beaudoin (simonbeaudoin0935) wants to merge 1 commit into
Conversation
Move the required variables, prerequisites, default branch, and per-environment reviewer/protection settings that configure-repo checks and applies out of Python constants and into tools/repo-configs.json, so the configuration can be read and audited without going through the script. ensure_required_reviewers() now takes an allow_admin_bypass parameter instead of always requiring bypass disabled, and the Staging-specific "no protection rules" check is folded into the same per-environment loop as the reviewer-enforced environments, both driven by the new config data. No functional change other than this. Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Simon Beaudoin (simonbeaudoin0935)
requested review from
Robie Basak (basak-qcom) and
Loïc Minier (lool)
September 2, 2026 21:05
Simon Beaudoin (simonbeaudoin0935)
linked an issue
Simon Beaudoin (simonbeaudoin0935)
deleted the
issue-22-repo-config-script
branch
September 2, 2026 23:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configure-repochecks and applies out of Python constants and intotools/repo-configs.json, so the configuration can be read and audited without going through the scriptensure_required_reviewers()to take anallow_admin_bypassparameter instead of always requiring bypass disabledrepo-configs.jsonintools/README.mdNo functional change other than this (one cosmetic output diff: a blank line now separates every environment's protection-rule section, including Staging, since it's part of the same loop).
This lays the groundwork for further
configure-repochecks (tracked in #22) to be added as config data rather than hardcoded Python.Validation
python3 -m py_compile tools/configure-repopython3 -c "import json; json.load(open('tools/repo-configs.json'))"./tools/configure-repo --check pkg-example— output matches pre-refactor behavior aside from the noted blank-line differenceRefs qualcomm-linux/qli-ci#22