.github/workflows: skip jobs in forks - #90
Open
Loïc Minier (lool) wants to merge 1 commit into
Open
Conversation
Four workflows self-trigger on push, pull_request, or schedule and fail or misbehave when this repo is forked: build-test needs DEBUSINE_TOKEN, the container build pushes to ghcr.io/qualcomm-linux, the preflight checks are Qualcomm-specific, and stale-issues would comment on a fork's own issues. Guard each job on the repository owner. Assisted-by: Claude Code:claude-opus-5 Signed-off-by: Loïc Minier <loic.minier@oss.qualcomm.com>
Robie Basak (basak-qcom)
requested changes
Aug 4, 2026
Robie Basak (basak-qcom)
left a comment
Robie Basak (basak-qcom)
left a comment
Contributor
There was a problem hiding this comment.
Most of this looks good but I'm unsure about one specific change. Question inline.
| name: Run QC Preflight Checks | ||
| # Qualcomm-specific checks (commit email, copyright, repolinter) that are | ||
| # not meaningful in a fork. | ||
| if: github.repository_owner == 'qualcomm-linux' |
Contributor
There was a problem hiding this comment.
I agree with the others. But if our aim is to accept PRs from forks, I think we do want this one, no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four workflows self-trigger on push, pull_request, or schedule and
fail or misbehave when this repo is forked: build-test needs
DEBUSINE_TOKEN, the container build pushes to
ghcr.io/qualcomm-linux, the preflight checks are Qualcomm-specific,
and stale-issues would comment on a fork's own issues. Guard each
job on the repository owner.