fix(build-linux-deb): honour --local-dir for config - #539
Open
Loïc Minier (lool) wants to merge 1 commit into
Open
fix(build-linux-deb): honour --local-dir for config#539Loïc Minier (lool) wants to merge 1 commit into
Loïc Minier (lool) wants to merge 1 commit into
Conversation
The merge_config.sh and olddefconfig invocations passed a hardcoded
cwd="linux" while the defconfig and bindeb-pkg invocations used
linux_dir. With --local-dir pointing anywhere other than ./linux,
the config phase fails with FileNotFoundError: 'linux'.
Use linux_dir consistently. The default clone path is unaffected, as
linux_dir is Path("linux") there.
Assisted-by: Claude Code:claude-opus-5
Signed-off-by: Loïc Minier <loic.minier@oss.qualcomm.com>
Test jobs for commit caf0c12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merge_config.sh and olddefconfig invocations passed a hardcoded
cwd="linux" while the defconfig and bindeb-pkg invocations used
linux_dir. With --local-dir pointing anywhere other than ./linux,
the config phase fails with FileNotFoundError: 'linux'.
Use linux_dir consistently. The default clone path is unaffected, as
linux_dir is Path("linux") there.