fix: set correct state before writing output - #1752
Open
Vanshika Turakhia (vansvan17) wants to merge 2 commits into
Open
fix: set correct state before writing output#1752Vanshika Turakhia (vansvan17) wants to merge 2 commits into
Vanshika Turakhia (vansvan17) wants to merge 2 commits into
Conversation
Vanshika Turakhia (vansvan17)
requested a review
from quic-areg
as a code owner
August 22, 2026 00:31
Vanshika Turakhia (vansvan17)
requested a review
from Shankar Easwaran (quic-seaswara)
as a code owner
August 23, 2026 11:32
Parth (parth-07)
approved these changes
Aug 23, 2026
Signed-off-by: Vanshika <vanshikaturakhia@gmail.com>
Signed-off-by: Vanshika <vanshikaturakhia@gmail.com>
Parth (parth-07)
force-pushed
the
fix/act-before-writing-output-state
branch
from
August 27, 2026 06:29
61484ce to
a043146
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LinkState::ActBeforeWritingOutputbefore invoking the corresponding plugin hookTesting
ELFObjectWriter.cppwith the generated external-LLVM compile commandActBeforeWritingOutputPlugin.cppagainst LLVM 22.1.8.commentinline assembly being rejected by the Mach-O assemblerFixes #1728