[ARM] Implement R_ARM_LDR_PC_G1 relocation - #1789
Draft
Steven Ramirez Rosa (Steven6798) wants to merge 1 commit into
Draft
[ARM] Implement R_ARM_LDR_PC_G1 relocation#1789Steven Ramirez Rosa (Steven6798) wants to merge 1 commit into
Steven Ramirez Rosa (Steven6798) wants to merge 1 commit into
Conversation
Steven Ramirez Rosa (Steven6798)
requested review from
quic-areg and
Shakti Suman (quic-shaksuma)
as code owners
August 28, 2026 19:40
Steven Ramirez Rosa (Steven6798)
marked this pull request as draft
August 28, 2026 19:46
Add support for R_ARM_LDR_PC_G1 by sharing the ARM LDR PC-group residual encoding logic and wiring the relocation to the ARM apply table. The implementation extracts the signed LDR literal addend, computes S + A - P, selects the output U bit from the displacement sign, and writes the group residual into the imm12 field with overflow checking. Add standalone ARM relocation coverage for both a valid R_ARM_LDR_PC_G1 encoding and an overflow case where the group residual does not fit in imm12. Fix: qualcomm#1770 Signed-off-by: Steven Ramirez Rosa <ramirezr@qti.qualcomm.com>
Steven Ramirez Rosa (Steven6798)
force-pushed
the
issue-1770
branch
from
August 28, 2026 20:56
fa791a5 to
19be9ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for R_ARM_LDR_PC_G1 by sharing the ARM LDR PC-group residual encoding logic and wiring the relocation to the ARM apply table. The implementation extracts the signed LDR literal addend, computes S + A - P, selects the output U bit from the displacement sign, and writes the group residual into the imm12 field with overflow checking.
Add standalone ARM relocation coverage for both a valid R_ARM_LDR_PC_G1 encoding and an overflow case where the group residual does not fit in imm12.
Fix: #1770