Move InputType::Archive and DynObj to SearchDirs::SearchInputType#958
Open
parth-07 wants to merge 1 commit intoqualcomm:mainfrom
Open
Move InputType::Archive and DynObj to SearchDirs::SearchInputType#958parth-07 wants to merge 1 commit intoqualcomm:mainfrom
parth-07 wants to merge 1 commit intoqualcomm:mainfrom
Conversation
This commit moves InputType::Archive and InputType::DynObj to a newly created enum SearchDirs::SearchInputType. Input::InputType::Archive and Input::InputType::DynObj were very misleading because we create no inputs of these types. Additionally, one of the other InputType enum value is Namespec, making it theoretically possible for an input to be both Namespec and Archive/DynObj. This is wrong because Type-like enum values should be disjoint. Signed-off-by: Parth Arora <partaror@qti.qualcomm.com>
parth-07
force-pushed
the
SearchInputType
branch
from
4feca93 to
a865550
Compare
quic-seaswara
approved these changes
Mar 23, 2026
Contributor
|
Is this NFC ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit moves InputType::Archive and InputType::DynObj to a newly created enum SearchDirs::SearchInputType. Input::InputType::Archive and Input::InputType::DynObj were very misleading because we create no inputs of these types. Additionally, one of the other InputType enum value is Namespec, making it theoretically possible for an input to be both Namespec and Archive/DynObj. This is wrong because Type-like enum values should be disjoint.