Skip to content

Conversation

hoisinberg
Copy link
Collaborator

@hoisinberg hoisinberg commented Jul 22, 2025

Closes #7517

Follow up to #7500, which listed this notebook in SKIP_NOTEBOOKS in order to get past CI breakages due to the fact that the notebook tests install the fully-released version of Cirq. Once the parameter renaming is released, this can be removed.

@github-actions github-actions bot added the Size: XS <10 lines changed label Jul 22, 2025
@hoisinberg hoisinberg force-pushed the u/hoisinberg/virtual-engine-notebook-test branch from b0d73c0 to df6ccd2 Compare July 22, 2025 22:11
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@hoisinberg hoisinberg force-pushed the u/hoisinberg/virtual-engine-notebook-test branch from df6ccd2 to a3655b4 Compare July 22, 2025 22:50
@github-actions github-actions bot added size: S 10< lines changed <50 and removed Size: XS <10 lines changed labels Jul 22, 2025
@hoisinberg hoisinberg force-pushed the u/hoisinberg/virtual-engine-notebook-test branch from a3655b4 to f9725de Compare July 22, 2025 22:55
@hoisinberg hoisinberg changed the title Move docs/simulate/virtual_engine_interface.ipynb to NOTEBOOKS_DEPENDING_ON_UNRELEASED_FEATURES Indicate that docs/simulate/virtual_engine_interface.ipynb depends on unreleased features Jul 22, 2025
@hoisinberg hoisinberg force-pushed the u/hoisinberg/virtual-engine-notebook-test branch from f9725de to 4bea360 Compare July 22, 2025 23:05
@hoisinberg hoisinberg requested a review from pavoljuhas July 22, 2025 23:10
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.52%. Comparing base (86b38ab) to head (4bea360).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7528      +/-   ##
==========================================
- Coverage   97.53%   97.52%   -0.01%     
==========================================
  Files        1095     1095              
  Lines       99002    99016      +14     
==========================================
+ Hits        96560    96568       +8     
- Misses       2442     2448       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hoisinberg hoisinberg marked this pull request as ready for review July 22, 2025 23:36
@hoisinberg hoisinberg requested review from vtomole and a team as code owners July 22, 2025 23:36
@hoisinberg hoisinberg requested a review from fdmalone July 22, 2025 23:37
@mhucka mhucka self-assigned this Jul 23, 2025
@hoisinberg hoisinberg added this pull request to the merge queue Jul 23, 2025
Merged via the queue into main with commit bbbf952 Jul 23, 2025
154 of 163 checks passed
@hoisinberg hoisinberg deleted the u/hoisinberg/virtual-engine-notebook-test branch July 23, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move docs/simulate/virtual_engine_interface.ipynb to NOTEBOOKS_DEPENDING_ON_UNRELEASED_FEATURES
3 participants