Treat classically controlled ops as non-Clifford in dynamical_decoupling
#7621
+19
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Classically controlled operations were passing `_is_clifford_op`, which led `dynamical_decoupling` to synthesize/invert through them and crash. Mark them non-Clifford for DD so they act as boundaries. Add regression test `test_classically_controlled_no_update_succeeds`. Fixes quantumlib#7617
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7621 +/- ##
==========================================
- Coverage 99.56% 99.37% -0.20%
==========================================
Files 1088 1078 -10
Lines 96083 96060 -23
==========================================
- Hits 95667 95456 -211
- Misses 416 604 +188 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
daxfohl
reviewed
Aug 31, 2025
daxfohl
reviewed
Aug 31, 2025
babacry
reviewed
Sep 11, 2025
Comment on lines
+65
to
+67
| add_dynamical_decoupling( | ||
| cirq.Circuit( | ||
| cirq.Moment(measure(a, key="a")), cirq.Moment(I(a).with_classical_controls("a")) |
There was a problem hiding this comment.
could you validate the transformed circuit:
cirq.testing.assert_same_circuits(input_circuit, output_circuit)
babacry
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classically controlled operations were passing
_is_clifford_op, which leddynamical_decouplingto synthesize/invert through them and crash. Mark them non-Clifford for DD so they act as boundaries. Add regression testtest_classically_controlled_no_update_succeeds.Fixes #7617