Attempt to reduce spurious linkage errors #48965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the `RunnerClassLoader` is (more or less) lockless, if a class is concurrently redefined, we can get a spurious `LinkageError` which is consumed and ignored. We can reduce this incidence by doing one last probe for the loaded class before we attempt to define it but after we have done all of the resource loader work.
quarkus-bot
bot
added
the
area/devtools
geoand
approved these changes
Jul 17, 2025
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✖ | Native Tests - Windows support | Build |
Failures | Logs | Raw logs | 🔍 |
You can consult the Develocity build scans.
Failures
⚙️ Native Tests - Windows support #
- Failing: integration-tests/liquibase
📦 integration-tests/liquibase
✖ Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-liquibase: Failed to build quarkus application
|
FYI it could be related to #43022? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
RunnerClassLoaderis (more or less) lockless, if a class is concurrently redefined, we can get a spuriousLinkageErrorwhich is consumed and ignored. We can reduce this incidence by doing one last probe for the loaded class before we attempt to define it but after we have done all of the resource loader work.Related to #39952.