-
Notifications
You must be signed in to change notification settings - Fork 3k
Deprecate SmallRye Metrics #49884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Deprecate SmallRye Metrics #49884
Conversation
/cc @ebullient (metrics), @gsmet (hibernate-orm), @jmartisk (metrics) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d6936ad
to
2fcf402
Compare
Status for workflow
|
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs | Build scan |
---|---|---|---|---|---|---|
❌ | Quickstarts Compilation - JDK 17 | Compile Quickstarts |
Failures | Logs | Raw logs | 🚧 |
You can consult the Develocity build scans.
Failures
⚙️ Quickstarts Compilation - JDK 17 #
- Failing: microprofile-metrics-quickstart
📦 microprofile-metrics-quickstart
❌ Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project microprofile-metrics-quickstart: Failed to build quarkus application
Are we ok to include this on the next LTS? |
The "next LTS" (3.27) is scheduled for Final release today... So I have serious doubts about that TBH, given that it's a breaking change and coming at the last minute, I don't think so. Let's hear what @gsmet thinks, but my guess is this will need to go in to 3.29 (3.28 is also releasing today, right?) |
We discussed this on Zulip some time ago, and we opened the PR 2 weeks ago: Unfortunately, it went under the radar. I would like to avoid having to keep this for yet another year. |
To clarify, this is not removing the extension, is just disabling it (if being used), with a warning message and a configuration to reenable it again. The change is minimal. |
IIUC it will fail the build unless the user explicitly adds a new property, so I wouldn't exactly call it minimal. Well, @gsmet has already kicked off 3.27.0 and 3.28.0 releases, so this discussion is now moot anyway. |
This PR fails the build when using Quarkus SmallRye Metrics for increased awareness of our intention to remove the extension (after the next LTS). The extension can be reenabled by setting
quarkus.smallrye-metrics.deprecated.enabled=true
.