Skip to content

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Sep 4, 2025

This PR fails the build when using Quarkus SmallRye Metrics for increased awareness of our intention to remove the extension (after the next LTS). The extension can be reenabled by setting quarkus.smallrye-metrics.deprecated.enabled=true.

Copy link

quarkus-bot bot commented Sep 4, 2025

/cc @ebullient (metrics), @gsmet (hibernate-orm), @jmartisk (metrics)

This comment has been minimized.

Copy link

github-actions bot commented Sep 4, 2025

😭 Deploy PR Preview failed.

This comment has been minimized.

@radcortez radcortez force-pushed the deprecate-sr-metrics branch from d6936ad to 2fcf402 Compare September 4, 2025 17:01
Copy link

quarkus-bot bot commented Sep 4, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 2fcf402.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Sep 4, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 2fcf402.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
Quickstarts Compilation - JDK 17 Compile Quickstarts Failures Logs Raw logs 🚧

You can consult the Develocity build scans.

Failures

⚙️ Quickstarts Compilation - JDK 17 #

- Failing: microprofile-metrics-quickstart 

📦 microprofile-metrics-quickstart

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project microprofile-metrics-quickstart: Failed to build quarkus application

@radcortez radcortez requested review from gsmet and jmartisk September 16, 2025 11:56
@radcortez
Copy link
Member Author

Are we ok to include this on the next LTS?

@jmartisk
Copy link
Contributor

The "next LTS" (3.27) is scheduled for Final release today... So I have serious doubts about that TBH, given that it's a breaking change and coming at the last minute, I don't think so. Let's hear what @gsmet thinks, but my guess is this will need to go in to 3.29 (3.28 is also releasing today, right?)

@radcortez
Copy link
Member Author

We discussed this on Zulip some time ago, and we opened the PR 2 weeks ago:
https://quarkusio.zulipchat.com/#narrow/channel/187038-dev/topic/Remove.20quarkus-smallrye-metrics/with/537063154

Unfortunately, it went under the radar. I would like to avoid having to keep this for yet another year.

@radcortez
Copy link
Member Author

To clarify, this is not removing the extension, is just disabling it (if being used), with a warning message and a configuration to reenable it again. The change is minimal.

@jmartisk
Copy link
Contributor

IIUC it will fail the build unless the user explicitly adds a new property, so I wouldn't exactly call it minimal. Well, @gsmet has already kicked off 3.27.0 and 3.28.0 releases, so this discussion is now moot anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants