removed platform sdk dependency #540
Draft
+112
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smedhe
requested review from
quic-rishinr,
ochougul,
quic-hemagnih and
quic-amitraj
as code owners
quic-mamta
reviewed
Aug 19, 2025
Signed-off-by: Sharvari Medhe <[email protected]>
ochougul
requested changes
Aug 21, 2025
QEfficient/generation/cloud_infer.py
Outdated
Comment on lines
24
to
30
| if QAICInferenceSession._qaicrt is None: | ||
| try: | ||
| QAICInferenceSession._qaicrt = importlib.import_module("qaicrt") | ||
| except ImportError: | ||
| sys.path.append(f"/opt/qti-aic/dev/lib/{platform.machine()}") | ||
| QAICInferenceSession._qaicrt = importlib.import_module("qaicrt") | ||
| return QAICInferenceSession._qaicrt |
There was a problem hiding this comment.
It is not required to check if the model is already loaded or not.
Python automatically does this.
https://stackoverflow.com/questions/19077381/what-happens-when-a-module-is-imported-twice#:~:text=Nothing%2C%20if%20a%20module%20has,modules%20).
There was a problem hiding this comment.
I have tested it on a system without Apps sdk and export is working fine.
QEfficient/generation/cloud_infer.py
Outdated
Comment on lines
34
to
40
| if QAICInferenceSession._aicapi is None: | ||
| try: | ||
| QAICInferenceSession._aicapi = importlib.import_module("QAicApi_pb2") | ||
| except ImportError: | ||
| sys.path.append("/opt/qti-aic/dev/python") | ||
| QAICInferenceSession._aicapi = importlib.import_module("QAicApi_pb2") | ||
| return QAICInferenceSession._aicapi |
QEfficient/generation/cloud_infer.py
Outdated
Comment on lines
19
to
20
| _qaicrt = None | ||
| _aicapi = None |
There was a problem hiding this comment.
It's not a good practice to have a module as a class variable. When you remove the dependency of checking if the module in already imported, this is not required.
There was a problem hiding this comment.
removed the class level variables storing the modules and updated the code.
Signed-off-by: Sharvari Medhe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates QEff to support QPC generation on systems without the Platform SDK by refactoring the module loading behavior. Users can now compile models and generate QPCs using QEff with only the Apps SDK installed.
Background: Previously, both Apps SDK and Platform SDK were required to compile and generate QPCs using QEff. The goal is to allow QPC generation with only the Apps SDK installed for systems without Ultra cards.
Changes:
Refactored init.py and generation/cloud_infer.py to use lazy loading via importlib for qaicrt and aicapi.
This ensures that Platform SDK-dependent modules are only loaded when explicitly needed, avoiding import errors during initialization and QPC generation.