Correcting issue regarding Calendar.getFirstDayOfWeek() which is dependent on locale#1147
Open
alexwibowo wants to merge 1 commit intoquickfix-j:masterfrom
Open
Correcting issue regarding Calendar.getFirstDayOfWeek() which is dependent on locale#1147alexwibowo wants to merge 1 commit intoquickfix-j:masterfrom
Calendar.getFirstDayOfWeek() which is dependent on locale#1147alexwibowo wants to merge 1 commit intoquickfix-j:masterfrom
Conversation
… wont start because of invalid interval date range.
chrjohn
requested changes
Feb 25, 2026
Member
chrjohn
left a comment
chrjohn
left a comment
There was a problem hiding this comment.
Could you please check if it works with these changes? We should be able to do without the added check.
Comment on lines
+241
to
+245
|
|
||
| // in some cases (certain locale), we could run into scenario where the interval end is before the interval start. | ||
| if (intervalEnd.getTimeInMillis() < intervalStart.getTimeInMillis()) { | ||
| intervalEnd.add(Calendar.WEEK_OF_YEAR, 1); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| // in some cases (certain locale), we could run into scenario where the interval end is before the interval start. | |
| if (intervalEnd.getTimeInMillis() < intervalStart.getTimeInMillis()) { | |
| intervalEnd.add(Calendar.WEEK_OF_YEAR, 1); | |
| } |
chrjohn
reviewed
Feb 25, 2026
| @@ -236,6 +238,11 @@ private TimeInterval theMostRecentIntervalBefore(Calendar t) { | |||
| if (intervalEnd.getTimeInMillis() <= intervalStart.getTimeInMillis()) { | |||
| intervalEnd.add(Calendar.WEEK_OF_MONTH, 1); | |||
Member
There was a problem hiding this comment.
Suggested change
| intervalEnd.add(Calendar.WEEK_OF_MONTH, 1); | |
| intervalEnd.add(Calendar.DAY_OF_YEAR, 7); |
chrjohn
requested changes
Feb 25, 2026
chrjohn
changed the title
Calendar.getFirstDayOfWeek() which is dependent on locale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1146