Add C Closures #1228
Draft
Add C Closures #1228
+90
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows C objects to be attached to functions, and it also allows C code to be notified when these functions are finalized. Co-Authored-By: Andrew Krieger <[email protected]>
|
Thank you! Could you please add a test to api-test.c? |
bnoordhuis
reviewed
Nov 4, 2025
|
|
||
| /* XXX: could add the function on the stack for debug */ | ||
| if (unlikely(argc < s->length)) { | ||
| arg_buf = alloca(sizeof(arg_buf[0]) * s->length); |
There was a problem hiding this comment.
Needs a stack check:
Suggested change
| arg_buf = alloca(sizeof(arg_buf[0]) * s->length); | |
| stack_size = arg_buf[0]) * s->length; | |
| if (js_check_stack_overflow(rt, stack_size)) | |
| return JS_ThrowStackOverflow(ctx); | |
| arg_buf = alloca(sizeof(stack_size); |
As well, add a temporary JSStackFrame here, otherwise the function doesn't show up in stack traces. I fixed that recently for JSCFunctionData callbacks so you can just crib it from there: c85fd87
Comment on lines
+5600
to
+5602
| JSValue JS_NewCClosure(JSContext *ctx, JSCClosure *func, | ||
| int length, int magic, void *opaque, | ||
| void (*opaque_finalize)(void*)) |
There was a problem hiding this comment.
For consistency with e.g. JS_SetModuleLoaderFunc:
Suggested change
| JSValue JS_NewCClosure(JSContext *ctx, JSCClosure *func, | |
| int length, int magic, void *opaque, | |
| void (*opaque_finalize)(void*)) | |
| JSValue JS_NewCClosure(JSContext *ctx, JSCClosure *func, | |
| void (*opaque_finalize)(void*), | |
| int length, int magic, void *opaque) |
And I'd add a typedef for the finalizer callback.
Comment on lines
+5622
to
+5623
| js_function_set_properties(ctx, func_obj, | ||
| JS_ATOM_empty_string, length); |
There was a problem hiding this comment.
I added JS_NewCFunctionData2 recently because people do in fact sometimes want to set the function name, so let's do that right from the beginning here. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows C objects to be attached to functions, and it also allows C code to be notified when these functions are finalized.
Import of https://github.com/tbluemel/quickjscpp/blob/98bf1ddb00e39d93840c4b67211c9260943b5a83/patches/2024-01-13/0001-Add-C-Closures.patch. Trivial renaming of functions and function annotations to match local style.
Closes #1212. Closes tbluemel/quickjscpp#3.