Skip to content

add ability to retrieve ROI names in a case insensitive way #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raffaelespinoni wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add ability to retrieve ROI names in a case insensitive way #47

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8828d60
add ability to retrieve ROI names in a case insensitive way
Feb 22, 2022
f434fcd
Add test for case insensitivity
awtkns Feb 22, 2022
cc439b1
Code formatting
awtkns Feb 22, 2022
cab9a6b
solve NPE issue
Feb 23, 2022
44332b4
Merge branch 'main' into add_ability_to_retrieve_ROI_names_in_a_case_…
raffaelespinoni Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rt_utils/rtstruct.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def get_roi_mask_by_name(self, name) -> np.ndarray:
"""

for structure_roi in self.ds.StructureSetROISequence:
if structure_roi.ROIName == name:
if structure_roi.ROIName.casefold() == name.casefold():

@awtkns awtkns Feb 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

    def get_roi_mask_by_name(self, name: str) -> np.ndarray:
        """
        Returns the 3D binary mask of the ROI with the given input name
        """
        name = name.casefold() if type(name) is str else name

        for structure_roi in self.ds.StructureSetROISequence:
            if structure_roi.ROIName.casefold() == name:
                contour_sequence = ds_helper.get_contour_sequence_by_roi_number(
                    self.ds, structure_roi.ROINumber
                )
                return image_helper.create_series_mask_from_contour_sequence(
                    self.series_data, contour_sequence
                )

        raise RTStruct.ROIException(f"ROI of name `{name}` does not exist in RTStruct")

It may be safer to check that name is not none before calling .casefold() as shown above.

contour_sequence = ds_helper.get_contour_sequence_by_roi_number(
self.ds, structure_roi.ROINumber
)
Expand Down