Skip to content

[Bugzilla #18938] seq(<Date>, <char>, by=1) "just works" #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Bugzilla #18938] seq(<Date>, <char>, by=1) "just works" #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e3ca89
#18938: seq(<Date>, <char>, by=1) "just works"
MichaelChirico Aug 21, 2025
769bcc6
3 more tests
MichaelChirico Aug 21, 2025
0ad562f
remove an indirectly-related test
MichaelChirico Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/library/base/R/dates.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,9 +293,9 @@ seq.Date <- function(from, to, by, length.out = NULL, along.with = NULL, ...)
if(is.na(by)) stop("'by' is NA")

res <- switch(missing_arg,
from = seq.int(to = unclass(to), by = by, length.out = length.out),
to = seq.int(from = unclass(from), by = by, length.out = length.out),
length.out = seq.int(from = unclass(from), to = unclass(to), by = by)
from = seq.int(to = unclass(as.Date(to)), by = by, length.out = length.out),
to = seq.int(from = unclass(as.Date(from)), by = by, length.out = length.out),
length.out = seq.int(from = unclass(as.Date(from)), to = unclass(as.Date(to)), by = by)
)
.Date(res)
}
Expand Down
14 changes: 13 additions & 1 deletion tests/datetime3.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,7 +786,19 @@ identicalPlt <- function(x, y, ...)
stopifnot(identicalPlt(z1, z), identicalPlt(z2, z))
## failed previously, incl in rev 88441


## strings in one argument of seq.Date always get coerced
from_str <- "2025-01-01"; to_str <- "2025-01-07"
full_seq <- seq(as.Date(from_str), as.Date(to_str))
stopifnot(exprs = {
identical(seq(as.Date(from_str), to_str), full_seq)
identical(seq(as.Date(from_str), to_str, by=1L), full_seq)
identical(seq(as.Date(from_str), to_str, length.out=7L), full_seq)
identical(seq(to=as.Date(to_str), length.out=7L, by=1L), full_seq)
identical(seq(from=as.Date(from_str), length.out=7L, by=1L), full_seq)
identical(seq(to=as.Date(to_str), from_str), full_seq)
identical(seq(to=as.Date(to_str), from_str, by=1L), full_seq)
identical(seq(to=as.Date(to_str), from_str, length.out=7L), full_seq)
})

## keep at end
rbind(last = proc.time() - .pt,
Expand Down
Loading