Bump tools and deps #1938
Merged
Bump tools and deps #1938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not merge: there is a legitimate failure in kubectl tests |
This prevents warnings of version mismatch between installed ginkgo CLI and ginkgo version used in tests.
[Why] After PR rabbitmq/rabbitmq-server#14359 RabbitMQ verifies that an authN/authZ plugin is enabled, if set in the configuration. We relied on the old behaviour that simply accepted the configuration. We have to change our test because the configuration is not valid anymore since 4.2.0
|
kubectl tests are now passing 🤷♂️ There was a legitimate failure in system tests because one test relied on an "undocumented feature" related to rabbitmq/rabbitmq-server#14359 Our test was setting the rabbitmq authentication backend to LDAP, but it did not enable the LDAP plugin. Prior to 4.2.0, this was valid configuration. After the mentioned PR, rabbit fails at boot. Our test now simply uses a different configuration in advanced config. |
MirahImage
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, dependabot has not created PRs for this yet