Skip to content

Conversation

chengjoey
Copy link
Contributor

This closes #1949

Note to reviewers: fix unnecessary warnings

Summary Of Changes

Additional Context

Local Testing

Please ensure you run the unit, integration and system tests before approving the PR.

To run the unit and integration tests:

$ make unit-tests integration-tests

You will need to target a k8s cluster and have the operator deployed for running the system tests.

For example, for a Kubernetes context named dev-bunny:

$ kubectx dev-bunny
$ make destroy deploy-dev
# wait for operator to be deployed
$ make system-tests

@chengjoey
Copy link
Contributor Author

/assign @VannTen @MirahImage

@Zerpet
Copy link
Member

Zerpet commented Sep 10, 2025

Hi @chengjoey, thank you for contributing to the cluster operator!

Since the 28th of July 2025, all external contributors to RabbitMQ will have to sign a CLA again [1].

The process is not complicated. Simply send us an email from the address you are committing your work, as described in [2].

Note companies that contribute to RabbitMQ only need to sign the CLA once, there is no need to make every
contributing employee to do so separately.

[1] https://github.com/rabbitmq/rabbitmq-server/blob/main/CONTRIBUTING.md
[2] https://github.com/rabbitmq/cla

Copy link
Member

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking PR on CLA

@MirahImage
Copy link
Member

CLA has been signed

@MirahImage
Copy link
Member

FYI, the test failures will resolve themselves if you rebase the PR on main.

@Zerpet Zerpet added this to the 2.17.0 milestone Sep 10, 2025
@Zerpet Zerpet merged commit 01d088f into rabbitmq:main Sep 10, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't warn when only requests.limits are set on a RabbitmqCluster object
3 participants