Fix race condition on connection closing #813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The broker can close a connection abruptly (in case of re-authentication fails) and the application can call Client#close() at the same time. There can be a race condition whereby the call to close() triggers a regular closing initiated by the client but the Netty channel is already inactive. The call to close() then blocks until it reaches the RPC timeout. This commit makes sure the channel is still active before trying to send the close command to the broker.
github-actions bot
pushed a commit
that referenced
this pull request
Aug 20, 2025
Fix race condition on connection closing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The broker can close a connection abruptly (in case of re-authentication fails) and the application can call Client#close() at the same time. There can be a race condition whereby the call to close() triggers a regular closing initiated by the client but the Netty channel is already inactive. The call to close() then blocks until it reaches the RPC timeout.
This commit makes sure the channel is still active before trying to send the close command to the broker.