Skip to content

Preserve the source encoding when building multipart uploads #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OskarEichler wants to merge 1 commit into from
+12 −1
Closed

Preserve the source encoding when building multipart uploads #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/rack/test/utils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ def build_file_part(buffer, parameter_name, uploaded_file)

# Handle old versions of Capybara::RackTest::Form::NilUploadedFile
if uploaded_file.respond_to?(:set_encoding)
uploaded_file.set_encoding(Encoding::BINARY)
uploaded_file.append_to(buffer)
end

Expand Down
12 changes: 12 additions & 0 deletions spec/rack/test/utils_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,18 @@
describe 'Rack::Test::Utils.build_multipart' do
include Rack::Test::Utils

it 'preserves the source encoding of uploaded StringIO content' do
source = +"café"
file = Rack::Test::UploadedFile.new(
StringIO.new(source),
original_filename: 'content.txt'
)

Rack::Test::Utils.build_multipart('file' => file)

source.encoding.must_equal Encoding::UTF_8
end

it 'builds multipart bodies' do
files = Rack::Test::UploadedFile.new(multipart_file('foo.txt'))
data = Rack::Test::Utils.build_multipart('submit-name' => 'Larry', 'files' => files)
Expand Down