Gtk: confine the screen size fix to affected versions #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruifengx
force-pushed
the
ruifengx/fix-gtk-screen-size
branch
from
eab0023 to
995275f
Compare
|
Do I need to take any actions regarding the CI failures? I think it's the CI configuration itself that needs an update. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following lines applies a fix to workaround the upstream GTK regression:
gui/gui-lib/mred/private/wx/gtk/frame.rkt
Lines 608 to 615 in aea05e8
However, the regression is now fixed upstream for GTK >= 3.24.42 (link to the line in the release notes). As a result,
slideshowslides, for example, are displayed in only half of my screen size, which turns out to be exactly the same bug inevince(the PDF viewer).In this PR, I apply the same fix as in
evince, to confine the workaround to only affected versions of GTK (>= 3.24.9 and < 3.24.42). I have confirmed with a local patch that it fixes the problem on my device.