Skip to content

Conversation

@tiemvanderdeure
Copy link
Collaborator

closes #1032

_is_op_threadsafe(::typeof(maximum)) = true
# Identical to Base.PermutedDimsArrays.CommutativeOps but define here to avoid
# using base internals
const COMMUTATIVE_OPS = Union{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const COMMUTATIVE_OPS = Union{
const CommutativeOps = Union{

Actually a type not a constant

typeof(*)
}

_is_op_threadsafe(::COMMUTATIVE_OPS) = true
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_is_op_threadsafe(::COMMUTATIVE_OPS) = true
_is_op_threadsafe(::CommutativeOps) = true

@tiemvanderdeure
Copy link
Collaborator Author

I really have no clue what is going on in the Documentation build. Seems to be some git issue?

@asinghvi17
Copy link
Collaborator

No, there is some problem in an example block, but it doesn't tell me which example block for some reason. Very weird - normally it does.

@lazarusA
Copy link
Collaborator

it is a link (asset) that is not downloading. We definitely need an independent source for these kind of assets. Basically, any USA based related link is a gamble.

@rafaqz
Copy link
Owner

rafaqz commented Nov 11, 2025

Got a link to where that is? I can only see logging related errors

@lazarusA
Copy link
Collaborator

ahh no, sorry this is the issue ( ? is a Makie issue) @asinghvi17 ?

Warning: failed to run `@example` block in docs/src/tutorials/plot_makie.md:45-54
│ ```@example makie
│ # `stack` is the WorldClim climate data for January
│ stack_obs = Observable(stack)
│ fig = Rasters.rplot(stack_obs;
│     Colorbar=(; height=Relative(0.75), width=5)
│ ) 
│ record(fig, "rplot.mp4", 1:12; framerate = 3) do i
│     stack_obs[] = RasterStack(WorldClim{Climate}; month = i)
│ end
│ ```
│   exception =
│    TypeError: non-boolean (Missing) used in boolean context
│    Stacktrace:
│      [1] _setproperty!

@asinghvi17
Copy link
Collaborator

I thought we commented that out?

@asinghvi17
Copy link
Collaborator

But that can just get deleted probably and maybe if someone can file an issue about that, I can get around to looking at it soonish

@tiemvanderdeure
Copy link
Collaborator Author

Ah if it's still that issue I made a PR to makie to fix it: MakieOrg/Makie.jl#5327

@tiemvanderdeure
Copy link
Collaborator Author

I think we can merge this? The documentation issue will be fixed whenever the Makie folks bump ComputePipeline

@rafaqz rafaqz merged commit 025d98b into main Nov 12, 2025
4 of 5 checks passed
@rafaqz rafaqz deleted the tvd/commutative_rasterize branch November 12, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

threadsafe operations are handled as if they were not threadsafe

5 participants